Comments (12)
adding another blank line fails precommit scripts too https://github.com/pre-commit/pre-commit-hooks/blob/master/pre_commit_hooks/end_of_file_fixer.py
in my case version bump is part of ci process which results in precommit failures like:
hookid: end-of-file-fixer
Files were modified by this hook. Additional output:
Fixing .bumpversion.cfg
would be nice to make this configurable. meanwhile have to skip precommit on bump file itself
from bumpversion.
Yep, I think it shouldn't append another additional blank line.
from bumpversion.
Seems like a warning originating from git / your specific git config. Can you post your git config --list
output (please remember strip auth tokens etc. (!)) ?
from bumpversion.
Cool, thanks for your response. This is my git config --list
result, I can't find any related config inside.
[email protected]
user.name=YuLun Shih
core.editor=vim
url.https://.insteadof=git://
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
from bumpversion.
I might have fixed this as part of making the tests run on windows (are you running windows btw?) here: #64 (comment)
Can you install the current version by executing
pip install https://github.com/peritus/bumpversion/archive/master.zip#egg=bumpversion-dev
and let me know if the problem still persists ?
from bumpversion.
It works like a charm TY!
from bumpversion.
Just curious, are you using windows ?
from bumpversion.
@peritus Oop! I just found out If I use nano editor it works! It only happens when I use sublime text with editorconfig plugin.
Btw, I am using Debian.
This is my .editorconfig
file
# EditorConfig helps developers define and maintain consistent
# coding styles between different editors and IDEs
# editorconfig.org
root = true
# We recommend you to keep these unchanged
[*]
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
[*.js]
# Change these settings to your own preference
indent_style = space
indent_size = 2
[*.py]
# Change these settings to your own preference
indent_style = space
indent_size = 4
[*.md]
trim_trailing_whitespace = false
from bumpversion.
http://stackoverflow.com/questions/27059239/git-new-blank-line-at-eof seems to be a valuable resource here.
from bumpversion.
This could be the culprit:
insert_final_newline = true
As far as I understand it's recommended to have a newline character (also known as \n) at the end of a file, but not a 'blank line' (that's what git is complaining about here).
from bumpversion.
Yes, I have read this article before, but what I am noticed is after executing bumpversion patch
the .bumpversion.cfg
is added "another blank line" for me. That cause the problem.
from bumpversion.
You're right. bumpversion
indeed adds a blank line to the config file after writing. The question is: Should it ?
from bumpversion.
Related Issues (20)
- Multi-line `replace` doesn't work for lines starting with `#` HOT 2
- Missing allowed 'part' values in commandline help HOT 2
- All strings matching current version are bumping up in setup.py file. HOT 2
- Issue while using search and replace configurations. HOT 2
- Do not fail on the dirty state during the dry-run HOT 1
- How to keep the metadata part when bumping version?
- bump version number in filename
- Bumpversion --list returned non-zero exit status 1 HOT 1
- Improvement README.rst
- TypeError: 'NoneType' object is not iterable HOT 1
- Release version from working branch
- search-replace falls back to plain version lookup in some cases HOT 1
- help need: error while serialize following pattern (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)\.(?P<build>\d+)
- No Pre-Release Tags if Major Version is 0 HOT 1
- bumpversion w/ added "commit" part adding additional parts to files
- Add ability to specify a value of a part of version only HOT 1
- Need better documentation on multiline support for `search` and `replace`
- Is it possible to allow {current_[part]} / {new_[part]} in search/replace?
- Dependencies versions in pyproject.toml altered casually
- Is it possible to make numbered beta versions like in npm?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bumpversion.