.bumpversion.cfg:7: new blank line at EOF. about bumpversion HOT 12 OPEN

adding another blank line fails precommit scripts too https://github.com/pre-commit/pre-commit-hooks/blob/master/pre_commit_hooks/end_of_file_fixer.py

in my case version bump is part of ci process which results in precommit failures like:

hookid: end-of-file-fixer

Files were modified by this hook. Additional output:

Fixing .bumpversion.cfg

would be nice to make this configurable. meanwhile have to skip precommit on bump file itself

from bumpversion.

Yep, I think it shouldn't append another additional blank line.

from bumpversion.

Seems like a warning originating from git / your specific git config. Can you post your git config --list output (please remember strip auth tokens etc. (!)) ?

from bumpversion.

Cool, thanks for your response. This is my git config --list result, I can't find any related config inside.

[email protected]
user.name=YuLun Shih
core.editor=vim
url.https://.insteadof=git://
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true

from bumpversion.

I might have fixed this as part of making the tests run on windows (are you running windows btw?) here: #64 (comment)

Can you install the current version by executing

pip install https://github.com/peritus/bumpversion/archive/master.zip#egg=bumpversion-dev

and let me know if the problem still persists ?

from bumpversion.

It works like a charm TY!

from bumpversion.

Just curious, are you using windows ?

from bumpversion.

@peritus Oop! I just found out If I use nano editor it works! It only happens when I use sublime text with editorconfig plugin.
Btw, I am using Debian.

This is my .editorconfig file

# EditorConfig helps developers define and maintain consistent
# coding styles between different editors and IDEs
# editorconfig.org

root = true

# We recommend you to keep these unchanged
[*]
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.js]
# Change these settings to your own preference
indent_style = space
indent_size = 2

[*.py]
# Change these settings to your own preference
indent_style = space
indent_size = 4

[*.md]
trim_trailing_whitespace = false

from bumpversion.

http://stackoverflow.com/questions/27059239/git-new-blank-line-at-eof seems to be a valuable resource here.

from bumpversion.

This could be the culprit:

insert_final_newline = true

As far as I understand it's recommended to have a newline character (also known as \n) at the end of a file, but not a 'blank line' (that's what git is complaining about here).

from bumpversion.

Yes, I have read this article before, but what I am noticed is after executing bumpversion patch the .bumpversion.cfg is added "another blank line" for me. That cause the problem.

from bumpversion.

You're right. bumpversion indeed adds a blank line to the config file after writing. The question is: Should it ?

from bumpversion.