Giter Club home page Giter Club logo

Comments (8)

ptgolden avatar ptgolden commented on May 13, 2024

Can we make a basic character substitution map so that special or accented characters match plaintext, or is this too complicated with Unicode?

https://www.npmjs.com/package/normalize-strings

from periodo-reconciler.

atomrab avatar atomrab commented on May 13, 2024

Well, there we go.

from periodo-reconciler.

ryanfb avatar ryanfb commented on May 13, 2024

Another way to do this is to normalize input to Unicode NFD (decomposed) and then use a regex to strip all accent class characters (in Ruby this is \p{M}).

from periodo-reconciler.

ptgolden avatar ptgolden commented on May 13, 2024

Yep, that's probably a better approach than relying on a whitelist of characters.

from periodo-reconciler.

ptgolden avatar ptgolden commented on May 13, 2024

Fixed by 48d5efd

from periodo-reconciler.

ptgolden avatar ptgolden commented on May 13, 2024

One issue with replacing Roman numerals with their Arabic equivalents is that the same processing is applied to both period labels and queries. Doing that replacement on a period label is no problem, since it's very unlikely that there would be a stray "I" "V" or "X" token appearing in a period label that was not a Roman numeral. However, there might be a situation where that would be the case in a query-- like if someone wanted all the periods that started with a "V". That's not a real case, but it's not far from one.

from periodo-reconciler.

atomrab avatar atomrab commented on May 13, 2024

But this comment is more about free-text searching than reconciliation, right? I would assume that one wouldn't have a dataset for reconciliation that just had letters like 'V' that weren't numerals.

from periodo-reconciler.

ptgolden avatar ptgolden commented on May 13, 2024

Yes, you're right. Implemented in #7 if @rybesh is fine with it!

from periodo-reconciler.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.