Giter Club home page Giter Club logo

Comments (8)

ptgolden avatar ptgolden commented on May 28, 2024

this should be done in a migration for the database so that existing added periods don't break.

from periodo-client.

atomrab avatar atomrab commented on May 28, 2024

Is this why the source locator for entries that have a page number rather than a URL doesn't appear in any of the period definitions?

from periodo-client.

ptgolden avatar ptgolden commented on May 28, 2024

locators appear as of b502ad3

from periodo-client.

atomrab avatar atomrab commented on May 28, 2024

Is this issue still being addressed? At least in the case of Yon, where the source locator was the same for all entries, the locator value doesn't appear in the list view or in the source-locator field in the edit view. In this case, the locator falls after the source in the JSON, not after the individual period assertions.

"type": "PeriodCollection",
"source": {
"partOf": {
"creators": [
{
"name": "Yon, Marguerite.",
"id": "http://viaf.org/viaf/75011781"
}
],
"title": "The city of Ugarit at Tell Ras Shamra",
"yearPublished": 2006,
"id": "http://www.worldcat.org/oclc/63390787"
},
"locator": "page 24"
},
"id": "p0zmdxz",

The same thing is true of periods in the collection "Near Eastern Archaeology. A Reader", all of which are defined on the same page (83), but NOT of Woolley 1982, whose periods are defined on different pages (here the source locator shows up fine in both the list and edit views).

from periodo-client.

ptgolden avatar ptgolden commented on May 28, 2024

Please do not reopen issues. I created this to track the implementation of storing locators for a particular period definition, which I finished this morning.

If you want to have a further discussion, you can comment without reopening the issue. What you are referring to is something different that we can discuss tomorrow.

from periodo-client.

ptgolden avatar ptgolden commented on May 28, 2024

the source-based locator now shows up in the collection page. It will not show up for individual period details. I don't have time to do any more than that.

from periodo-client.

atomrab avatar atomrab commented on May 28, 2024

Will this be true for new periods entered as we move forward (that is, if the collection only refers to one page, it will only appear in the collection detail, but if it refers to multiple pages, it will appear in the period details -- like Yon vs Woolley)? Or is this only the case for periods already in the dataset?

from periodo-client.

ptgolden avatar ptgolden commented on May 28, 2024

All of them, existing and future

from periodo-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.