Comments (6)
In both Chrome and Firefox, clicking the "Submit patch" button causes a spinning processing icon to appear at the top of the page, but nothing happens on the user side after that. When one clicks on "Submitted patches", nothing appears. Should there be some event on the user-interface side to show that something has happened?
We tested this by adding a period (Pre-Pottery Neolithic A) to an existing collection (King and Stager) in local idbs entitled "test1" in both cases (in case something shows up on the server side).
from periodo-client.
UPDATE: when we added a NEW collection (the British Museum thesaurus) with one new period, the "Submit Patch" produced the image below. The screen now includes the new collection (period itself not specified), the new period we'd previously added to an existing collection, and two periods that are listed as "edited" from the same existing collection that we're quite sure we did not just edit. It would be helpful in this case to see either a timestamp for the edit or some sort of view of the edits that had been made (I think this would be generally helpful, actually, for people to keep track of their own edits before submission, even if the bug is fixed).
from periodo-client.
UPDATE: submission of that patch (select all for new period collections and new periods) went through when I was logged in with my ORCID; "Submitted Patches" led to a page with the following message:
https://test.perio.do/patches/1/
Resolved? false
from periodo-client.
I'm going to create a new issue for things that don't have to do with accepting patches
from periodo-client.
Initial implementation in af1e5d4. Not deployed yet.
from periodo-client.
Patch acceptance is now implemented. If there are problems with anything, we should include them in a new, separate issue.
from periodo-client.
Related Issues (20)
- Submission of new period failing HOT 11
- Displayed period should default to selected period when not hovering HOT 2
- What purpose does the "File" data type in the source selection page now serve? HOT 7
- Alternate view of period list, through a settings button as for spatial coverage? HOT 2
- Disallow importing partial datasets from the server HOT 4
- Importing multiple individual authorities to a local data source -- persistent selection
- Putting in a marker for getting Palladio tools working
- Minor UI change to patch review page HOT 2
- Allow N2T URLs when adding Web data sources
- Update gazetteer-handling code to handle latest version of Linked Places Format
- Patch review page can get stale mergeURL value (because GetPatchRequest is not dispatched) HOT 9
- Error accepting changes for patch #281 on patch review page (Mac OS 10.12.6, Firefox 83.0) HOT 2
- Client not displaying in Safari (12.1.2) on Mac (Sierra 10.12.6) HOT 5
- Drawing a box to select places to filter by HOT 2
- Fix map zoom button styling HOT 1
- PeriodO Client not accepting all the changes made to an existing authority HOT 3
- Remove functionality to automatically fill authority source data from a Worldcat URI HOT 1
- Request contact info from submitters who do not have email in ORCID profile HOT 1
- Browser webGL error on up-to-date Firefox on older Windows 10 machine HOT 1
- Show nicer error when attempting to view non-existent authorities or periods HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from periodo-client.