Giter Club home page Giter Club logo

Comments (6)

atomrab avatar atomrab commented on May 27, 2024

In both Chrome and Firefox, clicking the "Submit patch" button causes a spinning processing icon to appear at the top of the page, but nothing happens on the user side after that. When one clicks on "Submitted patches", nothing appears. Should there be some event on the user-interface side to show that something has happened?

We tested this by adding a period (Pre-Pottery Neolithic A) to an existing collection (King and Stager) in local idbs entitled "test1" in both cases (in case something shows up on the server side).

from periodo-client.

atomrab avatar atomrab commented on May 27, 2024

UPDATE: when we added a NEW collection (the British Museum thesaurus) with one new period, the "Submit Patch" produced the image below. The screen now includes the new collection (period itself not specified), the new period we'd previously added to an existing collection, and two periods that are listed as "edited" from the same existing collection that we're quite sure we did not just edit. It would be helpful in this case to see either a timestamp for the edit or some sort of view of the edits that had been made (I think this would be generally helpful, actually, for people to keep track of their own edits before submission, even if the bug is fixed).

submit_patch_capture

from periodo-client.

atomrab avatar atomrab commented on May 27, 2024

UPDATE: submission of that patch (select all for new period collections and new periods) went through when I was logged in with my ORCID; "Submitted Patches" led to a page with the following message:

https://test.perio.do/patches/1/
Resolved? false

from periodo-client.

ptgolden avatar ptgolden commented on May 27, 2024

I'm going to create a new issue for things that don't have to do with accepting patches

from periodo-client.

ptgolden avatar ptgolden commented on May 27, 2024

Initial implementation in af1e5d4. Not deployed yet.

from periodo-client.

ptgolden avatar ptgolden commented on May 27, 2024

Patch acceptance is now implemented. If there are problems with anything, we should include them in a new, separate issue.

from periodo-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.