Cannot find module 'typescript' about percy-cypress HOT 8 CLOSED

Woop! Happy to hear that. If it does happen again I’d love to hear about it.

from percy-cypress.

Hi @Pomax , I see in Travis that you got it working at least once, but you had to add npm i typescript to your build script (I'm looking at this successful build: https://travis-ci.org/mozilla/foundation.mozilla.org/builds/486681759)

Did you ever get this working without having to manually install Typescript?

from percy-cypress.

I did not, but the steps to reproduce were pretty easy because it kept going wrong everywhere: install cypress 3.0.3, install @percy/cypres 0.2.3 and then just try to run percy. Anywhere we tried that we'd get the "typescript is not installed" error.

We ended up adding that explicit typescript install instruction mostly because we needed things to work because it was starting to mark every single PR as bad, and even if you can ignore percy, there as so many legitimate reasons a PR could get a red X next to it we had to solve the problem some way =)

from percy-cypress.

Did you also install @percy/agent? That's the package you need in order to be able to run the binary percy command.

from percy-cypress.

Scratch my previous comment -- @percy/agent comes as a dependency of @percy/cypress, so you don't need to install it explicitly.

from percy-cypress.

Unfortunately I can't reproduce the issue using those steps (and starting with making sure I don't have Typescript installed globally). Also tried to reproduce running the example app (https://github.com/percy/example-percy-cypress) from a clean install, but no dice.

from percy-cypress.

Hey @Pomax! Is this still an issue for you?

from percy-cypress.

I've not seen it happen recently, no. Closing until (if) it happens again

from percy-cypress.