Make running Percy integration optional about percy-cypress HOT 5 CLOSED

Hello @djones!

Sorry to reopen this one after such a long time but it seems like my tests running via ./node_modules/.bin/cypress run (so, without the percy command as I don't want Percy to be involved here, I need Cypress to run without Percy), my test is failing.

        "@percy/cli": "^1.0.0-beta.70",
        "@percy/cypress": "^3.1.1",

my become-seller.spec.js:

describe('Test the Become Seller page', () => {
  it('Goes on the registration page', () => {
    /**
     * @param {Object} routes.statics
     * @param {string} routes.statics.becomeSeller
     */
    cy.fixture('routes').then((routes) => {
      cy.visit(routes.statics.becomeSeller)
    })
    cy.window()
      .scrollTo('bottom', { duration: 50 })
    cy.percySnapshot()
  })
})

If I remove the cy.percySnapshot() it works well.

You can find the whole output here: https://gist.github.com/CyrilKrylatov/fff45dc898f77d4bc57103fe89edb2ef

Do you have any input on why the test is failing?

Thank you for your time. ✌️

Edit: oh, it's related to #434.

from percy-cypress.

I made Cypress plugin (cypress/plugins/index.js):

const process = require('process');

module.exports = (on, config) => {
  if (process.env.PERCY_TOKEN) {
    // eslint-disable-next-line no-param-reassign
    config.env.PERCY_ENABLED = true;
  }

  return config;
};

And now I can do:

if (Cypress.env('PERCY_ENABLED')) {
  cy.percySnapshot();
} 

from percy-cypress.

Hi @mitar, Thanks for reporting this and sharing your workaround.

Just to let you know I'm working on support for this feature this week. Percy shouldn't block your local test runs if it's not running.

I'll update the issue when there's progress made.

from percy-cypress.

@mitar if you upgrade to @percy/cypress 0.2.0 you can simply delete the code in your example above 😄

from percy-cypress.

Thanks!

from percy-cypress.