Giter Club home page Giter Club logo

Comments (8)

Robdel12 avatar Robdel12 commented on June 14, 2024

Hey @MatthD! How are you running percy exec? Are you using npx?

from percy-cypress.

MatthD avatar MatthD commented on June 14, 2024

Hi @Robdel12 I am using this script in my package.json for ci "test-functional-ci": "percy exec -- cypress run"

from percy-cypress.

Robdel12 avatar Robdel12 commented on June 14, 2024

Ah, gotcha. That makes sense. We use the latest version of Puppeteer which will download the version of chromium it needs. If you have chromium preinstalled on the CI image it might be worth locking puppeteer in your project to the same version installed on CI image.

We use 1.13 or greater: https://github.com/percy/percy-agent/blob/master/package.json#L36

Wanted to ask, is this causing issues for you or are you looking to save time and not download chromium?

from percy-cypress.

MatthD avatar MatthD commented on June 14, 2024

Oh yeah did not say, it's for saving time because of the downloading ;)

from percy-cypress.

bielcapanema avatar bielcapanema commented on June 14, 2024

@MatthD how did you solve this?

from percy-cypress.

MatthD avatar MatthD commented on June 14, 2024

Hum in fact I was not able to deal with that so just remove chrome from my docker image to have a smaller size et not to download it twice uselessly

from percy-cypress.

Robdel12 avatar Robdel12 commented on June 14, 2024

FWIW, we won't be moving away from Puppeteer any time soon. You might be able to provide env vars in CI that skips the Puppeteer download and then supply your own Chrome executable path: https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#environment-variables

Worth calling out their warning here too:

BEWARE: Puppeteer is only guaranteed to work with the bundled Chromium, use at your own risk.

I'm not sure if that will work, but its worth a shot if you would like to stop installing Chrome that's bundled with Puppeteer.

from percy-cypress.

Robdel12 avatar Robdel12 commented on June 14, 2024

Hey y'all! Wanted to come back to this and drop a doc for how to skip downloading Chrome if you know the path to an existing Chrome browser on the system: https://docs.percy.io/docs/skipping-puppeteer-chromium-download

from percy-cypress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.