Add empire support about placeholder HOT 11 OPEN

from placeholder.

can you please provide an example of this? I tried to reproduce this today without success.

from placeholder.

I tried US dependencies like The Virgin Islands, American Samoa and Puerto Rico. In all three cases the empire ID is visible in the spelunker but not in the source data.

from placeholder.

related whosonfirst/whosonfirst-www-spelunker#129

from placeholder.

tried Cook Islands and the hierarchy has been completely deleted as per whosonfirst-data/whosonfirst-data#954

from placeholder.

same for Niue, I'm going to stop digging now, there appear to be widespread issues with deleted hierarchies in WOF that surfaced recently.

I'm not sure if it's isolated to dependency records but they certainly seem badly affected.

from placeholder.

the functionality which adds empire to results seems to be working fine for other placetypes and I don't know any reason why it would differ for dependency, eg:

New Zealand country 85633345
└ New Zealand empire 136253053
   └ Oceania continent 102191583

from placeholder.

Let's please be careful with adding Empire properties to Pelias. I'd 100% like to avoid labels like this:

1204 H St, Eureka, California, United States (country), United States (empire)

I'm also not 100% sure that we need to say XYZ Street, Locality, American Samoa, United States.

Tread into these political waters at your own risk!

from placeholder.

We never include empire in the label so this shouldn't be a problem.

from placeholder.

K. And if empire started showing up on a locality WOF record, say, would you pass that thru in Pelias hierarchy result?

from placeholder.

We'll remove empires from the hierarchy unless there's no country, such as https://whosonfirst.mapzen.com/spelunker/id/85632421/

Unless you'd like that removed, too.

from placeholder.