Giter Club home page Giter Club logo

Comments (5)

seahawk1986 avatar seahawk1986 commented on July 17, 2024 1

I dug a little deeper into the setuptools documentation (https://setuptools.readthedocs.io/en/latest/setuptools.html?highlight=include_package_data#including-data-files) - the missing entries in the MANIFEST.in for those files seem to be the real cause for the missing files:

if using the setuptools-specific include_package_data argument, files specified by package_data will not be automatically added to the manifest unless they are listed in the MANIFEST.in file.

So including those files to the MANIFEST.in seems to be the better solution (the file tzwhere/tz_world.csv mentioned in MANIFEST.in has been removed in df871d2 )

#46 should fix the installation of those files.

from pytzwhere.

LowieHuyghe avatar LowieHuyghe commented on July 17, 2024

I'm having the same problem and would love to see it fixed!
Would it be possible to submit a pull request with your changes? Thanks in advance!

from pytzwhere.

pegler avatar pegler commented on July 17, 2024

Thanks @linwoodc3 and @seahawk1986 for the pull requests. I ended up using @linwoodc3's since it added compression. I just pushed version 3.0.2 to PyPI

from pytzwhere.

linwoodc3 avatar linwoodc3 commented on July 17, 2024

I'm an idiot. Careless mistake. I left the test name in the Manifest file.

This...

tzwhere/worldtest.json.gz

Needs to change to this...

include tzwhere/tz_world.json.gz

That's why the file is missing....

screen shot 2017-08-23 at 10 53 47 pm

from pytzwhere.

pegler avatar pegler commented on July 17, 2024

@linwoodc3 I just pushed v 3.0.3 with the fix

from pytzwhere.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.