"Goto/Peek Definition" doesn't work for proxy rules about code-peggy-language HOT 4 CLOSED

I have a few ideas for solving this problem:

The simplest just-delete-it solution

Simply remove the removeProxyRules function from Peggy transform pass. As far as I understand, this transform exists purely for optimization purposes. As the VSCode extension doesn't generate code, there's no actual need to perform that optimization.

The downside is that this eliminates the "Proxy rule 'foo' replaced by the rule 'bar'" info messages. I personally don't find these messages valuable. The blue squiggly line seems to suggest that there's something wrong with having a rule that's optimized away by the compiler. On the contrary I often find such rules useful for documentation purposes.

The complex work-around-the-problem solution

Store all the proxy rule removal messages and use that info later when performing the "Goto/Peek definition" action to navigate to the.

This seems like a pretty bad approach as we would be keeping the source of the problem, and working around the issues caused by that.

An intermediate make-it-harmless solution

Finally, we could replace the removeProxyRules transform pass with one that only reports these info messages, but doesn't perform the actual transform. That way the info messages would still be there, but the transformations would not cause "Goto/Peek definition" to fail.

from code-peggy-language.

I tried out the simple solution, which is pretty much a single line of code:

 const PASSES: peggy.compiler.Stages = {
   check: peggy.compiler.passes.check,
-  transform: peggy.compiler.passes.transform,
+  transform: peggy.compiler.passes.transform.filter(fn => fn.name !== "removeProxyRules"),
   generate: [getWarnings],
 };

from code-peggy-language.

I'm ok with just removing the compiler pass.

from code-peggy-language.

Awesome! Sent a PR.

from code-peggy-language.