Cannot save screenshots on Windows, works on MACos about shot HOT 3 OPEN

Did a few tests after forking the repository, the problem seems to be simple to solve, it's related to the last '\' on the path. I believe in windows it's not supposed to have the last '\'

original:

C:\Users\gusta\Documents\GitHub\Shot\shot-consumer-compose\app\screenshots\pro\debug\

how it worked on windows:

C:\Users\gusta\Documents\GitHub\Shot\shot-consumer-compose\app\screenshots\pro\debug

When i hardcoded without that last '\' the files started to save on windows, but now i'm facing a new error related to moving and comparing the screenshots. Probably also related to the last '\'.

That's the problem on Windows, but i'm finding it dificult to fix without breaking any existing code. If anyone more experienced with this code could take a look it would be a lot faster.

from shot.

Did a few more tests, and for some reason on windows you need to remove the '\' when creating a folder, but that '\' is needed when deleting the same folder. There's still one huge problem, but it's related to another issue.

Adb.scala

  private def executeAdbCommand(command: String): Int = {
    var newCommand = s"${adbPath} $command"
    if (newCommand.endsWith("/")) newCommand = newCommand.dropRight(1)
    if(newCommand.endsWith("\\"))newCommand= newCommand.dropRight(1)
    s"$newCommand" ! logger
  }

  private def executeAdbCommandWithResult(command: String): String = {
    var newCommand = s"${adbPath} $command"
    if (newCommand.endsWith("/")) newCommand = newCommand.dropRight(1)
    if (newCommand.endsWith("\\")) newCommand = newCommand.dropRight(1)
    s"$newCommand" !! logger
  }

That solved the copy problem on windows, but there's still the problem of not being able to delete "metadata.json" and "com.karumi.shotconsumercompose.MainActivityTest_activityTest_dump.json" due to them being used. When you try to run it again, it would lead to an error with metadata.json

Shot.scala

  private def safeDeleteDirectory(file: File): Unit = {
    var fileToDelete = file
    try {
      if(!fileToDelete.exists() && !fileToDelete.getAbsolutePath.endsWith("\\")) {
        fileToDelete = new File(file.getAbsolutePath+"\\")
      }
      FileUtils.deleteDirectory(fileToDelete)
    } catch {
      case e: Throwable => {
        println(YELLOW + s"Failed to delete directory: ${e}")
        println(YELLOW + s"Failed to delete directory: ${e.getCause.getCause}")
      }
    }
  }

Error when running safeDeleteDirectory

??  Pulling screenshots from your connected devices!

> Task :app:proDebugExecuteScreenshotTests                                                                                                                                                                                              
?  Saving screenshots.
?  Screenshots recorded and saved at: C:\Users\gusta\Documents\GitHub\Shot\shot-consumer-compose\app\screenshots\pro\debug\
?  You can review the execution report here: C:\Users\gusta\Documents\GitHub\Shot\shot-consumer-compose\app\build\reports\shot\pro\debug\index.html
Failed to delete directory: org.apache.commons.io.IOExceptionList: C:\Users\gusta\Documents\GitHub\Shot\shot-consumer-compose\app\screenshots\pro\debug\screenshots-default
Failed to delete directory: java.nio.file.FileSystemException: C:\Users\gusta\Documents\GitHub\Shot\shot-consumer-compose\app\screenshots\pro\debug\screenshots-default\com.karumi.shotconsumercompose.MainActivityTest_activityTest_dump.json: The process cannot access the file because it is being used by another process.

Running a second time after the error

 org.apache.commons.io.FileExistsException: File element in parameter 'null' already exists: 'C:\Users\gusta\Documents\GitHub\Shot\shot-consumer-compose\app\screenshots\pro\debug\screenshots-default\metadata.json_3297ed05'

from shot.

Same issue here unfortunately. Works fine on MACs, but not on Windows. And it's not only saving screenshots, it's running the tests themselves to compare and verify also suffer from the same problem ("? We couldn't find any screenshot. Did you configure Shot properly and added your tests to your project?")

from shot.