Comments (11)
@eduardb @AOrobator @juange87 we've fixed this issue and provided support for the latest versions of the Facebook core library. I'm about to release a new version with @Serchinastico and @tonilopezmr contributions.
from shot.
Congrats team!! 💪
And thank you for the support!
from shot.
Hi @juange87 thanks for reporting this bug. Just reading the stack trace makes me think this bug has to be related to the parsing of the XML metadata file the runner generates containing information about the tests execution. Could you please run the tests on any device or emulator you use, wait until the library fails and get a copy of the content you'll find at /tmp/shot/
? It has to be related to the document encoding or something similar, but without the metadata file I won't be able to fix it.
If the content of this folder contains sensitive information for you or your company review the content or share it directly with me through email. You can also create a new project on GitHub reproducing the error.
from shot.
Ok, I will try to do during the day.
I have more info related to this.
While setting up Shot, I made a change regarding this:
I changed the version to 0.5.0 (we had set Screenshot testing but It was not merged due to we hadn't a proper CI to run the Screenshot tests)
androidTestCompile ('com.facebook.testing.screenshot:core:0.5.0') {
exclude group: 'com.crittercism.dexmaker', module: 'dexmaker'
exclude group: 'com.crittercism.dexmaker', module: 'dexmaker-dx'
}
Last night at home I tried to record the tests again but changing this version to 0.4.2, and it worked as expected.
What make me think is, we are dropping the Facebook Screenshot testing configuration in favor of Shot, so the androidTestCompile ('com.facebook.testing.screenshot:core:0.4.2')
dependency should not affect us but if we remove it, we got the DexException
from shot.
I can reproduce this issue 100% of the time, and I've made a sample repo that you can take a look at here: https://github.com/AOrobator/ScreenshotTest.
Originally posted as an issue here: #34
from shot.
Thanks @AOrobator this repository is really helpful! Could you try by removing the facebook plugin from your classpath? Shot add all the dependencies needed to run your screenshot tests including the facebook lib.
from shot.
@pedrovgs Thanks that got me a bit further. Now I'm running into a separate issue which I've filed here: #35
from shot.
I ran as well into this issue, it seems that Shot is not working with version 0.5.0 of the facebook plugin. Which is a shame, since that version would solve the issue #35. I'm looking forward to seeing the update to make it work though :)
from shot.
Thanks for the notice, Pedro! :)
from shot.
You are welcome @eduardb are you using Shot for a personal or company project? We'd like to know if we have some users
from shot.
Hehe :) I am using it for a personal project, I started it very recently, and it's advancing slowly since I am working on it in my (limited) spare time. But I got introduced to the concept of screenshot testing at work on the web application we are working on, and it got me really excited to be able to do it on Android as well in such an easy way. Good job, btw! :)
from shot.
Related Issues (20)
- "Unresolved reference: shot" HOT 6
- `ManagedVirtualDevice` support HOT 2
- Snapshot on multipe devices only saving last screenshot HOT 1
- How to compare screens with dynamic content
- Screenshots get deleted after being recorded.
- XML report not showing failing tests HOT 1
- Failed to grant permissions HOT 2
- Waiting for remote image fetch HOT 1
- Generated diff image does not show all differences
- Removing the Toolbar shadow (elevation) HOT 1
- Is it possble to test screenshots for gif animated image?
- Feature Request / Question - Record Screenshots at Runtime HOT 2
- Failing to record screenshots HOT 8
- compareScreenshot to capture and verify full screen
- Support for Java 17 and AGP 8.0 HOT 1
- Failing landscape tests due to screen dimensions HOT 1
- Plugin not found issue with new plugin configuration method in gradle HOT 3
- Upgrade Scrimage to latest version
- Please consider transferring ownership to the community HOT 1
- Configuration with name 'androidTestImplementation' not found. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shot.