Not use preview, the aspect ratio of stream will be broken. about rootencoder HOT 3 CLOSED

Hello,

This should be fixed here:
e716ae1

I think I tested all cases but let me know if I missed something. I will upload the next version with the fixes soon

from rootencoder.

Hello,

I think it would be easier to use the sample by determining whether it is portrait or landscape when initializing the Fragment and setting it as the initial value.

Yes, this is an option but I think it is more confuse because the user can open in landscape, rotate to portrait and then start stream. The orientation will be horizontal in this case but If I open in Portrait and start stream the orientation is vertical and this could be confuse to understand.

I did it always horizontal and you can change it in the menu to vertical, this way it is easy to understand that you will stream horizontal until you change it in the menu.
I will keep the current way for this reason.

The error seem fixed. I will close the issue as completed but you can reopen it if you need or open other issue.
Thank you for the report

from rootencoder.

Hello,

I immediately checked the operation and confirmed that there were no problems in case 1 and case 2.

In case 1, CameraFragment's private var rotation is 0 by default,
so, I think sample codes assume landscape orientation.
I think it would be easier to use the sample by determining whether it is portrait or landscape when initializing the Fragment and setting it as the initial value.

and In case2,
after rewriting private var rotation = 90,
I commented out surfaceView.holder.addCallback and confirmed that it was streamed by Fit.

Thank you for your quick response.

from rootencoder.