Comments (4)
Thanks for the suggestions!
I would suggest an additional filter by nsites<100 or something reasonable, but unfortunately for COD they also do not know the nsites ahead of time until the positions have been computed. A possible workaround could be to give a reasonable upper bound on unit cell volume _cod_vol<10000 (the structure in question here has a volume of 167011 Å^3). Note, this is not the same as _cod_volume, which is for bibliographic references.
I think indeed it would be much better to restrict to lower cell volume. Not only this is breaking the query, but also this extremely large structures will (most of the time) break GSASII too, and the only way to fix it is by manually deleting those structures and uploading into the database.
I will run some tests, and if we can manage to filter out those structures through OPTIMADE, it might be better to replace the current COD querier that just downloads directly the CIF URLs.
(Having more general handling for 504 might be useful though, as you suggest)
I am wondering how would the best way to handle that for all cases. For now I will just raise an error, and limit the COD volume. If 504 still happens due to a different issue I will come back to think how to handle it.
Edit:
I have tested the _cod_vol< 10000 and it seems to be working quite nicely. It seems that we lost around 100 structures (for Si-O), although for the purposes of Xerus, they might just be noise and slow it down.
The only difference now is to check query speed by each interface.
from xerus.
I think this is related to the cartesian_site_positions
issue with COD, i.e. that they do not store them so must be reconstructed for every query. I raised an issue with the COD team (https://projects.ibt.lt/repositories/issues/1173) about the problem we faced when not restricting page limit (some bug in the internal logic was recalculating more structures than necessary for the response).
If you remove the response_fields
from that query it works instantly, and you can see the other data about that particular structure here: https://www.crystallography.net/cod/optimade/v1.1.0/structures/1552091. The problem seems to be that it is a 10000 atom cell (the chemical_formula_descriptive
field indicates O5280Si2640
) that would be very expensive to recompute the positions for.
I would suggest an additional filter by nsites<100
or something reasonable, but unfortunately for COD they also do not know the nsites
ahead of time until the positions have been computed. A possible workaround could be to give a reasonable upper bound on unit cell volume _cod_vol<10000
(the structure in question here has a volume of 167011 Å^3). Note, this is not the same as _cod_volume
, which is for bibliographic references.
Skipping the page would be annoying as you will lose the other structures from that page (unless you step through to find the offending structure).
from xerus.
(Having more general handling for 504 might be useful though, as you suggest)
from xerus.
This seems to be fixed by restricting the volume of COD structures, so I will close it for now.
from xerus.
Related Issues (20)
- Add timeout settings to Optimade querier HOT 2
- Allow to use first run simulations for subsequent runs of a given element space HOT 1
- Update Examples notebooks HOT 1
- How to handle multi user for the same installation? (Simultaneous query) HOT 1
- Finish the new testing method
- Change CI to be OS indepedent
- Deprecate 'tcif.py' and move testing to not be a script
- Change streamlit from input to forms
- Add option for 'is ceramic' in streamlit interface HOT 1
- Fix dummy not being added when a certain element combination returns no data
- Evaluate and Implement adding temperature restriction to COD
- Set HTTP `User-Agent` header for `requests` HOT 1
- Unable to run examples HOT 5
- Update to newest Materials project API HOT 1
- CI cannot install gfortran anymore HOT 3
- discussion: Repeat querying HOT 1
- GSASII Scriptable
- Black box optimizer
- Installation problem with conda/pip
- Any interest in adding the Alexandria database through the optimade api?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xerus.