Giter Club home page Giter Club logo

Comments (6)

GoogleCodeExporter avatar GoogleCodeExporter commented on June 24, 2024
I have enabled NPY_NO_DEPRECATED_API (see recent commit) in extension
modules and successfully tested compilation both with numpy 1.6.1 and git head
(under ubuntu with gcc and Python 2.6).
Hopefully this commit will fix the current issue without applying the
provided patch. Let me know how it works with Visual Studio compiler.

Original comment by pearu.peterson on 7 Nov 2011 at 8:18

  • Changed state: Accepted

from pylibtiff.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 24, 2024
I tested the code with SVN trunk and it does not compile. NPY_NO_DEPRECATED_API 
was introduced later than 1.6.1 (see ndarraytypes.h in 1.6.1: 
https://github.com/numpy/numpy/blob/v1.6.1/numpy/core/include/numpy/ndarraytypes
.h).

Original comment by [email protected] on 8 Nov 2011 at 8:12

from pylibtiff.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 24, 2024
Ok, thanks for the testing. The error could be raised because you are using
C++ compiler (which is probably more strict in pointer arithmetics) while
I don't get the error because I was using C compiler. Anyway, the patch
makes sense and I have applied it to svn.
Thanks for the bug report!

Original comment by pearu.peterson on 8 Nov 2011 at 8:28

from pylibtiff.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 24, 2024
And I would say that NPY_NO_DEPRECATED_API is irrelevant. Problematic is this 
commit: 
https://github.com/numpy/numpy/commit/c135371ea35483b5d557c04bcc57785b3edd9133#n
umpy/core/include/numpy/ndarraytypes.h that changes return type of PyArray_DATA.

Original comment by [email protected] on 8 Nov 2011 at 8:38

from pylibtiff.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 24, 2024
Thanks!

Original comment by [email protected] on 8 Nov 2011 at 8:38

from pylibtiff.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 24, 2024

Original comment by pearu.peterson on 8 Nov 2011 at 8:48

  • Changed state: Fixed

from pylibtiff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.