Allowing to create/change two tags with the same value about services_openstreetmap HOT 2 CLOSED

What you say doesn't seem to be supported by the newly added https://github.com/kenguest/Services_Openstreetmap/blob/master/tests/TagsWithSameValueTest.php test class, so I'm inclined to close this issue.

Perhaps you could submit a pull request with changes to the file TagsWithSameValueTest.php to convince me otherwise?

from services_openstreetmap.

I think the problem does not occur when you create a new node/way (as it is done in TagsWithSameValueTest.php). I ran your test and it indeed seemed like there was no problem. Then I tried it again with an existing node from the live OSM database and the problem reappeared.

array_diff($this->getTags(), $set) does compare $this->getTags() and $set.

Values are assigned to $set this way:

$set = array();
            for ($i = 0; $i < $tags->length; $i++) {
                $key = $tags->item($i)->getAttribute('k');
                $val = $tags->item($i)->getAttribute('v');
                $set[$key] = $val;
            }

$set contains the values of an object before your new ChangeSet is applied. Hence when you create a new object, $set is empty and array_diff($this->getTags(), $set) will save two tags with the same value. However, when you're editing an existing object, $set is not empty and the problem I described in my issue will appear.
Therefore I still sugesst removing this check.

from services_openstreetmap.