Peachpie.Runtime uses outdated System.Data.SqlClient 4.6.0 about peachpie HOT 4 CLOSED

Hi,

Thank you for the issue;

• the reference will be updated.
• you can disable the reference to Peachpie.App by setting <DisableImplicitPeachpieReferences>true</.. MSBuild property

from peachpie.

Thanks Jakub for the update. Turns out i am using Peachpie.NET.Sdk, too, so somehow even with <DisableImplicitPeachpieReferences>true</.. the System.Data.SqlClient gets linked.

Do you know this is going to be released this year?

from peachpie.

That should work, we're using it for years in production :/

Peachpie.NET.Sdk is the project build target, and it either adds a reference to Peachpie.App or not.

• Have you tried dotnet restore after changing the property?

FYI the dependencies look like this:

Peachpie.NET.Sdk -> <your.dll> -> Peachpie.App -> Peachpie.Library.MsSql -> System.Data.SqlClient

Peachpie.Runtime itself does not reference any Sql assemblies.

This is the dependency tree of a compiled PHP application, with <DisableImplicitPeachpieReferences>false</DisableImplicitPeachpieReferences> (default)

from peachpie.

Thank you, its working good now!

I was referencing Peachpie.NET.Sdk by package reference as below in msbuildproj file:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
	<DisableImplicitPeachpieReferences>true</DisableImplicitPeachpieReferences>  
  </PropertyGroup>  
  <ItemGroup>
    <PackageReference Include="Peachpie.NET.Sdk" Version="1.1.7" PrivateAssets="Build" />
  </ItemGroup>
</Project>

This way its still adding System.Data.SqlClient. When changing to the below, System.Data.SqlClient no longer being included...

<Project Sdk="Peachpie.NET.Sdk/1.1.9">
  <PropertyGroup>
	<DisableImplicitPeachpieReferences>true</DisableImplicitPeachpieReferences>
  </PropertyGroup>
</Project>

from peachpie.