Giter Club home page Giter Club logo

Comments (8)

pdreker avatar pdreker commented on September 13, 2024

I have never seen this on my box (7390 DSL). The fact that this also occurs with other means of reading the counter tells me, that this is something on the box itself (I assume firmware is current, just to state the obvious...).

You could try getting this to AVM, but due to the rather "special" nature of this glitch and the fact that it self-corrects I wouldn't hold my breath on a fix (too minor, too "random" for a quick fix).

I would probably just write it off as a bug but if this really annoys you or interferes with some other measurements derived from the counter I would probably try to setup a recording rule in prometheus to somehow filter the value. Also, as this exporter declares fritz_wan_data_bytes_total as a counter metric type (fritzexporter/fritzcapabilities.py around line 494ff) this triggers special handling in prometheus (wrap around detection etc.). This could cause more problems down the line. You might try changing the type to "gauge", but this will then obviously lose the ability for wrap around detection etc.

A recording rule which tries to check, if the value is "somewhat smaller than before" (there needs to be a threshold of some kind, as not to disturb the wrap around) and if this is the case, it will just take the previous value. Basically along the lines of (pseudocode!)

if (current_value - last_value < 0 AND current_value - last_value > -100000)
    current_value = last_value

Things like this can be hard to express in PromQL - you may have to resort to abusing something like aggregations or offsets to get the "last_value"...

I'll keep this open for the time being, maybe someone else can chime in with more infos.

from fritz_exporter.

pdreker avatar pdreker commented on September 13, 2024

Also I assume the values you posted above are directly from the box? Or did you read those from prometheus?

If the value are from prometheus: there was a bug, where this exporter would generate the same metric multiple times, if scraping multiple devices, which would lead to all kinds of "fun" problems, if the timestamps were not 100% identical. That said: your values all display different timestamps, so this should not be it.

If you are not running the latest version of this exporter (2.1.4), please try that version.

If your values are NOT from prometheus... disregard my ramblings ;-)

from fritz_exporter.

pdreker avatar pdreker commented on September 13, 2024

The latest version as of this comment ist obviously 2.2.4, not 2.1.4

from fritz_exporter.

pdreker avatar pdreker commented on September 13, 2024

Checking the timestamps: Scraping once a minute is totally OK. I had this running with a scrape every 15s for months (without host_info enabled) and it worked just fine.

from fritz_exporter.

joef42 avatar joef42 commented on September 13, 2024

Thanks for the response. Yes, I also suspect an issue on the box itself, but it is strange that I already saw this on two completely different FBs.

Didn't know about recording rules on Prometheus, I will probably look into this. Not perfect, but certainly easier than doing this with PromQL.

I should have the latest version and I'm only scrapping on FB right now, so don't think it is related to the bug you mentioned.

I will probably set up a recording rule as you mentioned and monitor the situation. Thanks for leaving this open for some while.

from fritz_exporter.

pdreker avatar pdreker commented on September 13, 2024

Recording Rules also use PromQL, so that won't save you from fiddling around with that. But you will have a stable counter in the Database this way.

from fritz_exporter.

joef42 avatar joef42 commented on September 13, 2024

True, but still seems easier that way than having to deal with this when building dashboards.

from fritz_exporter.

pdreker avatar pdreker commented on September 13, 2024

As part of my "end of year cleanup" I'll close this issue. Google should still pick it up. :-)

from fritz_exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.