default save and replace original file about pdfarranger HOT 12 CLOSED

from pdfarranger.

ctrl+s enter enter does not work for me due to window focusing paradigm and because I don't want my mouse to jump to newly opened dialogs (high risk of bad clicks).

for the risk of data loss, there's a thing called "using a temporary filename".

if you refuse to implement this, I will fork.

from pdfarranger.

It does not because pdfarranger is not rigorously a file modifier. The PyPDF2 import/export is not a transparent operation. If you add a PDF file to pdfarranger then save, PyPDF2 rewrite the whole file and possibly change it's structure. Most of the time we don't want the original file to be replaced because there is a high risk of data loss.

This is why the save action redirect to save as until the user has specified a file name to save to.

Here is what I suggest:

• if a single file (or no file) was imported and not modified
  • Quietly close
• else ask about save confirmation, and if yes
  • if the user as already manually run the save or save as action to select a different file name
    • Quietly save and close
  • else
    • Open a save as dialog

The implementation is linked to #59 because this is where I can get the modified status of the file.

from pdfarranger.

How is the risk of data loss addressed with this solution? I think it's rather serious since the exported file can be corrupted while the preview in pfarranger looks good. The user has no possibility to check the results before it's too late

from pdfarranger.

@dreua I did not implemented what OP asked for. A file chooser still popup at the first save, but now it default to the first imported PDF files. So before overwriting a file the user still have to confirm two times:

• Click save in the file chooser without changing the file name
• Confirm that he wants to overwrite

He can also blindly press ctrl+s, enter, enter which allow to get almost what OP wants.

from pdfarranger.

That sounds okay to me, thank you for the clarification!

from pdfarranger.

For me, the "save" dialog does not default to a filename, unfortunately. If it did that, I guess I could live with it (and #100 could be ignored).

Also, how do you get ctrl+s to work?

from pdfarranger.

@madduck For me the "save" dialog always defaults to a filename (pdfarranger 1.3.0 on Linux/Fedora) and ctrl+s just works. Unfortunately I can only look into your problem if there is a way for me to reproduce it.

from pdfarranger.

@petaflot it would be cool if you submitted a merge request. Also starts with a fork. ;)

from pdfarranger.

I'm looking at the code.

I figured "to make everyone happy, I'll add a "ctrl+alt+s shortcut". That doesn't make me happy:

WTF is this <Primary> name for ctrl? comments says "See ..." for list of keys", "Primary" is not in the list. Come on... am I supposed to try pseudo-random names to find out the correct binding?

from pdfarranger.

<Secondary> is obviously not recognized. Unless someone gives me a clue, I will just write a dirty hack that I will keep for myself instead of doing things properly

from pdfarranger.

days until I make my own distro: current_days_count -1

from pdfarranger.