Comments (4)
from alot.
I think it's only the test, it only affects some build environments and the application itself is probably fine.
from alot.
The test code is this:
@utilities.async_test
async def test_no_spawn_no_stdin_attached(self):
ui = utilities.make_ui()
cmd = g_commands.ExternalCommand('test -t 0', refocus=False)
await cmd.apply(ui)
ui.notify.assert_not_called()
The ExternalCommand
class is just mainly a wrapper around asyncio.create_subprocess_{exec,shell}
and here we run test -t 0
. In the next test (which succeeded) we run test -t 0
while sending some text to it from python and then expect the command to fail.
@kpcyrd I think "it seems the test heavily depends on the terminal attached to the build" is a little to strong, my conclusion would be "the test depends an any terminal being attached". And then my question is: Is there a terminal attached to the build? What kind of infrastructure are you using to run these tests? Do I assume correctly that test -t 0
in a shell would fail in that infrastructure?
And the question @pazz and @dcbaker is: This test was introduced in 5f96f0d , do we really need a terminal or can we test this some other way? What exactly are we trying to test?
from alot.
That set of tests is fixed in the next commit, which seems to be for #1137, so what's supposed to be tested is that the subprocess.Popen call is invoked with it's stdin
parameter populated correctly.
from alot.
Related Issues (20)
- Do not quit while the editor is open
- move irc channel from freenode to libera HOT 3
- New release? HOT 1
- change colorscheme at runtime ? HOT 1
- [master/cffi] AttributeError: 'Thread' object has no attribute 'get_toplevel_messages' HOT 7
- `No matching distribution found for notmuch2>=0.30` HOT 3
- Contact completion with khard HOT 2
- Not compatible with notmuch2 0.35 bindings HOT 15
- Act on multiple threads in search mode HOT 3
- Local hostname in Message-ID HOT 4
- Unknown values were found in config
- please make `get_body_text` more robust HOT 1
- prompt before overwriting files when saving attachments HOT 1
- ` extract_body_part` can receive empty strings and throws exceptions when it does
- Crash while trying to attach word .doc file: module 'magic' has no attribute '_libraries HOT 3
- Sort oldest first by newest email in thread HOT 1
- LookupError when displaying inbox with notmuch backend HOT 1
- Use Github Actions HOT 4
- would it be ok to convert installer to poetry ? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alot.