Giter Club home page Giter Club logo

Comments (3)

ljharb avatar ljharb commented on June 10, 2024 1

The file is certainly there, but the library isn't npm-installed, and parsing HTML for script tags seems like a very strange choice for things inside node_modules.

If a later version of jQuery works in IE 6-9, then I'm happy to update it ¯\_(ツ)_/¯

from es6-shim.

ljharb avatar ljharb commented on June 10, 2024

I'm not sure why the warning would appear at all for anyone but the developers of es6-shim (mainly me), given that jquery is a dev dependency, so consumers would never have it installed?

Additionally, like many CVEs in the JS world, this CVE is not actually a vulnerability unless it's used improperly (at which case it's a vulnerability in the thing using jQuery, not jQuery itself). In other words, this CVE should never have been filed on jQuery directly in the first place. Our use of jQuery doesn't involve unsanitized user input, so it's a false positive.

from es6-shim.

scott-m-sarsfield avatar scott-m-sarsfield commented on June 10, 2024

Well, I'm not really sure what whitesource has going on under the hood.

To be fair, when I did a fresh install (yarn), the file was still there.
Screen Shot 2020-06-15 at 4 51 08 PM

It picked up jquery from this:

<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.9.0/jquery.min.js" type="text/javascript"></script>

And for futher context, there's a number of in-between dependencies (Although I don't believe they'd impact what's in your node_modules folder.)

└─┬ @storybook/[email protected]
  └─┬ @storybook/[email protected]
    └─┬ [email protected]
      └── [email protected]

That being said, I very much agree with you that it's not a real vulnerability.

from es6-shim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.