For consistency, we should use circe-config instead of pureconfig.

This was closed by <a class="issue-link js-issue-link" data-error-text="Failed to load

Fixed with <a class="issue-link js-issue-link" data-error-text="Failed to load title"

Switch to circe-config about scala-pet-store HOT 5 CLOSED

pauljamescleary commented on May 17, 2024

Switch to circe-config

from scala-pet-store.

Comments (5)

franklinchou commented on May 17, 2024 1

This was closed by #123, no?

from scala-pet-store.

pauljamescleary commented on May 17, 2024

Is there an advantage to circe-config over pure-config? I am more-or-less curious as I haven't dived into a detailed comparison.

from scala-pet-store.

zakpatterson commented on May 17, 2024

I don't think there could be any measurable advantage, it just seems like a more natural choice for this project since we're already using circe. Also c-c doesn't do kebab-case like p-c does which seemed weird to me. Here's a line where I used it in another project, although we wouldn't need to use all the ApplicativeAsk complexity here:

https://github.com/clovellytech/http4s-modules/blob/master/db/src/main/scala/h4sm/db/config/package.scala#L21

from scala-pet-store.

zakpatterson commented on May 17, 2024

I went ahead and did it, let me know what you think.

from scala-pet-store.

zakpatterson commented on May 17, 2024

Fixed with #123, thanks @franklinchou !

from scala-pet-store.

Recommend Projects