Giter Club home page Giter Club logo

Comments (8)

srbarrios avatar srbarrios commented on July 26, 2024 2

Ok! I will, as soon as I can reproduce exactly the problem.
I tried now in my fork.. and recursivity works fine, but it doesn't in the PRs of my upstream, it might be related to forked branches, not sure, so as soon I clarify I open an issue to discuss about it ;)
Thanks Paul.

from periodic-labeler.

MichalPetryka avatar MichalPetryka commented on July 26, 2024 1

Apparently, the 2nd one from labeler example isn't supported:

#WORKS
# Add 'label1' to any changes within 'example' folder or any subfolders
label1:
  - example/**/*

#DOESN'T WORK
# Add 'label2' to any file changes within 'example2' folder
label2: example2/*

from periodic-labeler.

paulfantom avatar paulfantom commented on July 26, 2024 1

Yeah, I didn't test something/**/* matchers... Could you open a separate issue about it as it is a different bug?

from periodic-labeler.

ilyam8 avatar ilyam8 commented on July 26, 2024 1

/**/* support added in #8

from periodic-labeler.

srbarrios avatar srbarrios commented on July 26, 2024

Apparently, the 2nd one from labeler example isn't supported:

#WORKS
# Add 'label1' to any changes within 'example' folder or any subfolders
label1:
  - example/**/*

#DOESN'T WORK
# Add 'label2' to any file changes within 'example2' folder
label2: example2/*

Hi,

In my case it works only with the second example 🤷‍♂️

from periodic-labeler.

paulfantom avatar paulfantom commented on July 26, 2024

@srbarrios are you sure? I am personally using the first example in all @cloudalchemy repositories (example) and it works there. Also, I investigated codebase and the second example cannot possibly work in golang due to how the data structure is defined (https://github.com/paulfantom/periodic-labeler/blob/master/main.go#L93) - it expects a map of lists.

I am open to PRs fixing this issue, but personally I don't have time to add this right now.

from periodic-labeler.

srbarrios avatar srbarrios commented on July 26, 2024

Hi @paulfantom , here https://github.com/uyuni-project/uyuni/pull/1711/files I tried to reformat using the first example, as I thought the problem was to have the filter inline with the label, instead of having it in a new line. But then the matcher /**/* didn't catch any file, then I tried only with /* and it catched the files in the root folder but still the recursivity is not working for me.

TBH I didn't have time to play a lot with that GitHub Action. I might be still doing something wrong, looking into your commented example, it might work if I include both /**/* and /*.

I'll let you know when I have some minutes to play with it :)

Thank you!

from periodic-labeler.

mehmet-erim avatar mehmet-erim commented on July 26, 2024

Is there any news?

from periodic-labeler.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.