Comments (2)
Well, silly me, turns out the icons are just squares in the node version and circles in the php version. So that's settled.
As far as the code view not working. Uncommenting these lines in source/_patternlab-files/index.mustache fixed the issue.
<script src="styleguide/js/annotations-viewer.js "></script>
<script src="styleguide/js/code-viewer.js "></script>
Code viewer works for me now.
from patternlab-node.
@jfitzsimmons2 Thanks for catching this one! I recall commenting this out early during the port - as I wanted to utilize @dmolsen awesome client-side work but didn't want to commit to the additional features until some of the internals were ready.
Seems like we are ready - I will give it a whirl and then check out the PR.
from patternlab-node.
Related Issues (20)
- Retrieve Google Fonts locally
- JavaScript error when opening the UI
- Bug: Code panels
- engine-twig-php: include-function syntax not matched by findPartials HOT 2
- startup error on TwigRenderer
- Nothing compiling to patterns folder HOT 1
- [Documentation] Engine configuration fileExtension vs extension HOT 6
- [Feature/Bug]: Code blocks in the markdown file do not show as code highlighted text HOT 8
- Rework how pattern lab loads UI-kits HOT 3
- Rework UI-kit Workshop
- Broken starter kit Twig Demo HOT 2
- Twig does not reload template on changes (PHP and node) HOT 3
- Rewrite Pattern Lab Core HOT 3
- Subitems would get cropped or disappear on vertical navigation
- PHP TwigRenderer Error when adding custom Twig extension via alter-twig.php HOT 1
- Patternlab and D10 / Twig 3 HOT 3
- [Vulnerability] Old version of lodash causing `npm audit` issues flagged HOT 2
- [Handlebars] Inconsistent data access when leveraging sibling JSON + partial blocks
- Migrate to Node 18
- Migrate from `pretty-quick` to `lint-staged`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from patternlab-node.