Giter Club home page Giter Club logo

Comments (5)

patrickdavey avatar patrickdavey commented on May 22, 2024 1

So the line that allows us to override it github/markup@d3430c3 hasn't been released yet. Once github-markdown releases a new version then I'll be able to turn off the escaping of all tags. Until then, fresh outa luck (unless you want to manually edit the ruby files yourself)

from vimwiki_markdown.

patrickdavey avatar patrickdavey commented on May 22, 2024 1

I thought of a way to (nastily) hack my way around the issue, seems to work. I've released 0.4.1, should allow your iframe tags now @bmedicke

from vimwiki_markdown.

patrickdavey avatar patrickdavey commented on May 22, 2024

Yip, I actually looked at that when I last upgraded the dependencies on vimwiki_markdown. From memory, commonmarker didn't expose a way to set UNSAFE at the time.

The markup gem now supports the commonmarker options, so, I've upgraded vimwiki_markdown and pushed out 0.4.0. So, upgrade vimwiki_markdown and it should allow your HTML now @bmedicke . Let me know if you run into issues.

from vimwiki_markdown.

bmedicke avatar bmedicke commented on May 22, 2024

Thanks for the fast update. The html does make it through but it is (partially) entity encoded.

<iframe width="560" height="315" src="" frameborder="0" allowfullscreen></iframe>

from vimwiki_markdown.

patrickdavey avatar patrickdavey commented on May 22, 2024

Hmmm, I only tested against the <p> tag - which is passed through OK. Looks like there's a tagfilter option which disallows certain tags - of which iframe is one, see the tagfilter here -> https://github.com/gjtorikian/commonmarker#extensions .

No idea how to turn that off yet, I'll have a look when I have time.. not sure there's an easy way.

from vimwiki_markdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.