[Backend] Feature Request: Pin Notes about notykt HOT 13 CLOSED

I think both the ways should okay:

• Single API with body
• Separate APIs without body

But it seems unusual/unconventional to have PUT/POST request without body.
Single API with body should be the ideal way to implement.

from notykt.

I think both the ways should okay:

• Single API with body
• Separate APIs without body

But it seems unusual/unconventional to have PUT/POST request without body.
Single API with body should be the ideal way to implement.

Makes sense!

from notykt.

Heyy @PatilShreyas I can take this up... should I start working on this feature??

from notykt.

Thanks for showing interest in contributing this @mrfamouskk7. Sure, Assigning this to you.

from notykt.

Thanks for showing interest in contributing this @mrfamouskk7. Sure, Assigning this to you.

Thanks @PatilShreyas

from notykt.

Let me know if you need any help in setting up this project locally.

from notykt.

Actually, I am done with local setup.
I just had a question, so isPinned flag will be required while fetching notes as well right? So should I include that in same PR??

from notykt.

Yes, it'll be required to have isPinned flag in all notes response. If you're fine with doing it in the same PR, then okay. Otherwise we can also have a dedicated PR for that.

from notykt.

@mrfamouskk7 Current API looks good to you?

Otherwise, we can also have two API endpoints for pin and unpin operations.

Like,

• PUT /note/{noteId}/pin
• PUT /note/{noteId}/unpin

This will not require a request body.

WDYT?

from notykt.

Yes, it'll be required to have isPinned flag in all notes response. If you're fine with doing it in the same PR, then okay. Otherwise we can also have a dedicated PR for that.

I will include in the same PR

from notykt.

Heyy Shreyash, so I have a couple of suggestions:

• Pinning API can be changed from PUT request to a PATCH request. PATCH is more suitable because we are not updating the complete resource here.
• A new field updated can be added to notes so that the most recent pinned note will be at the top

WDYT?

from notykt.

@mrfamouskk7 this sounds good to me. Definitely we can have updated field

from notykt.

Sure... I will add those changes in the same PR 👍

from notykt.