Comments (6)
tushar-dadlani
commented on July 18, 2024
.null is on android on iOS it shows up as (null)-someid.data
improved the filename for android, need someone to test, for iOS - will need to do something like https://github.com/react-native-community/react-native-share#share-remote-pdf-file-with-gmail--whatsapp-ios
I have made some changes here: https://github.com/tushar-dadlani/private-kit/tree/tdadlani/fix_share_name
would love your thoughts before I open a PR
from safeplaces-dct-app.
tremblerz
commented on July 18, 2024
Looks good based on changes, haven't tested it yet. Can you open a PR @tushar-dadlani ?
from safeplaces-dct-app.
tushar-dadlani
commented on July 18, 2024
I am breaking this into 3 parts
- Save file to disk with the correct name
- Share the file from filesystem
- delete the file locally
from safeplaces-dct-app.
tremblerz
commented on July 18, 2024
I would recommend avoiding that route if possible because other Apps can pickup for the time it is on disk (making the data non-private in a sense). At the same time I am aware of this issue being the library issue not ours so take your call.
from safeplaces-dct-app.
tremblerz
commented on July 18, 2024
Export on iOS is still an issue when sent as an attachment on Apps like gmail and whatsapp
from safeplaces-dct-app.
tremblerz
commented on July 18, 2024
Fixed in #283
from safeplaces-dct-app.
Related Issues (20)
- PathCheck GPS app is named PathCheck BT HOT 1
- iOS Accessibility testing reveals no accessibilityRole for checkbox
- Color code in "PathCheck is saving the places" screen
- Warning message in "PatchCheck is saving the places" screen HOT 2
- React Native CLI uses autolinking error, please help thankyou. HOT 2
- Path Check BT crashes when executed HOT 4
- Unlink react-native-local-resource
- Android notification channels (categories) SAF-782 HOT 3
- GPS export crashes on missing ExportCodeInput screen HOT 1
- Can someone please translate this? HOT 1
- 00 HOT 2
- [FEATURE-REQ] SHA256 of geohashes in the intersection code HOT 4
- Change standard home indicator colors HOT 1
- WebView not resizing the content to fit width of the screen in the FAQ page HOT 6
- [BUG] Problem when starting up the app on an AVD HOT 2
- Expanding circles on main screen not always properly centered HOT 3
- Onboarding Screen for location permission is flickering on iOS HOT 4
- Enabling location permission is missing during Onboard and Setting screen. HOT 2
- [Onboarding] - Permissions Flow Bugs HOT 5
- Android location permission showing denied intially HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from safeplaces-dct-app.