Comments (3)
@thompson-tomo thanks for raising the issue. There are reasons why we structured the dependencies the way we did, and removing it at this point would be a breaking change.
from nservicebus.
I don't see it as a breaking change if the framework ie net 8 still provides that dependency.
from nservicebus.
I don't see it as a breaking change if the framework ie net 8 still provides that dependency.
@thompson-tomo System.Security.Cryptography.Xml is not part of the BCL for .NET 8, so I'm not sure what you mean here. That functionality is only included in the package.
System.Security.Cryptography.Xml is included in the .NET Framework BCL, but the functionality is in the System.Security assembly and not split out into a separate assembly like it is for .NET. That's why the package includes an assembly with TypeForwardedTo
attributes to ensure the types can be loaded properly in all scenarios. I'm assuming this forwarding assembly is what you're referring to as a polyfil.
The primary reason we prefer not to condition dependencies based on target frameworks is that it leads to a more consistent experience. It avoids problems where it is possible to build an intermediate class library assembly that takes a dependency on the implementation assembly from the package, but when that intermediate assembly is used by an application, the forwarding assembly is not included as part of the application's dependencies, leading to runtime failures.
If we were to remove a package dependency at this point, anything built with the assumption of that package being referenced could observe a break of some kind. Given that there's no actual problem with having a potentially unneeded forwarding assembly in the bin output of your .NET Framework application, and that removing it could actually cause a break, we are not going to remove package dependencies outside of a new major version of NServiceBus.
If your .NET Framework application works fine without having System.Security.Cryptography.Xml.dll included, then you can always add a post-compilation step to your build that deletes it!
from nservicebus.
Related Issues (20)
- For OpenTelemetry metrics, allow Func<string, string> to be specified to trim the enclosed message types tag HOT 6
- Saga and outbox persistence that uses Entity Framework
- Overriding the host name does not work consistently
- AssemblyScanner finds private classes HOT 1
- Obsolete NServiceBus.Logging in favor of Microsoft.Extensions.Logging
- DefineCriticalErrorAction access to IServiceProvider HOT 3
- Support for Azure Event Hubs (Kafka) HOT 1
- Support for Azure Event Grid (MQTT)
- Messages cannot be sent from Windows to Linux using the file share data bus HOT 1
- Providing an empty license string throws an exception HOT 3
- Creating an endpoint and not referencing the instance results in memory/resource leak HOT 1
- Add tests for scenarios without `InstallersEnabled`
- Allow user to define the scope of a trace HOT 1
- Dispatch binary messages in incoming message context via `ReadOnlyMemory<Char>` or `Stream`
- Register multiple serializers for outgoing messages
- Customizable envelope formatting (Integration, standardization, interop) HOT 1
- Make it easier to use the hosting builder from Microsoft.Extensions.Hosting
- `IMessageSerializer` is not registered in DI and cannot be injected when replacing `SerializeMessageConnector`
- OpenTelemetry Metrics: Emit an UpDownCounter (gauge) for active handlers HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nservicebus.