xone: Hori Horipad - Non-repsonsive analog sticks about xpad HOT 12 CLOSED

xpad-2016.12.31_bd4f517_4.9.0_master-x86_64-1_git

I compiled the current git master and pleasantly found that this has already been fixed, thanks! I will close this now.

If you don't mind me asking, when is the current master supposed to be merged into the kernel?

from xpad.

Interesting. I guess it must be bd4f517. I was hoping to see if we could also get #48 fixed (likely with additional init packets) before going upstream with the patch. If we have to send more than 2 init packets, we'll need to do sequencing that would require rewriting the majority of the patch.

from xpad.

Thanks for the info, I'm more than happy to wait until you think its ready for it to be merged upstream. Also that is pretty good luck on my part that it was fixed the day before it came in the mail!

from xpad.

@orbea Can you try with this xpad.c to confirm it still works properly? http://pastebin.com/raw/Re8xby26

from xpad.

@cgutman I tried that xpad.c and I've encountered problems. Testing in sdl1-jstest, sdl2-jstest or RetroArch and the analog sticks will work at first, but quickly after changing to another program to test they will stop working. I'll have to test the master more to make sure this doesn't also happen there.

I don't see anything in dmesg.

from xpad.

It at least does not happen nearly as fast with the master, I will continue testing.

from xpad.

The git master certainly works.

from xpad.

Thanks, can you test my "for_upstream" branch? https://github.com/cgutman/xpad

If that works, may I add a "Tested-By: Firstname Lastname Email address" from you for my submission upstream?

from xpad.

@cgutman I tried your branch, it had the same result as before. The analog sticks work at first, but then quickly stop responding.

from xpad.

@orbea Ah, I think I understand the issue. Let me fixup my branch.

from xpad.

@orbea Please try again with my "for_upstream" branch. I've amended the patches with a fix for your issue.

Each time the device was opened, it was starting over from 0 in the sequence numbers in each packet. Your gamepad was rejecting the initialization packets after the first open because it wasn't expecting sequence numbers to start from 0 again.

from xpad.

@cgutman I have tried your branch again, this time the initial problem is gone.

However for reference this controller still has these two issues. #61 #62

from xpad.