x360w: only expose connected devices about xpad HOT 6 CLOSED

The bug is caused by discontinuing listening to the wireless adapter, which is done here: https://github.com/paroj/xpad/blob/connected_only/xpad.c#L687

Even if a device isn't physically connected to the adapter, this is how the adapter tells you whether a controller is connected or not. You must always be listening.

from xpad.

The adapter has a hard limit for 4 controllers. On top of this, there are only 4 LED positions. The original XUSB driver also only supported 4 controllers. I remember why I only supported 4 controllers with Xpad5

from xpad.

yeah.. I probably should just go with intf->cur_altsetting->desc.bInterfaceNumber for enumerating the wireless controllers.

But this is the usecase I am thinking about and which is covered by the current atomic counter approach:

1. attach a wired x360 pad (LED1)
2. connect a wireless x360 pad (LED2)
   the 5th controller is identified by LED1 again

However the counter just keeps incrementing after suspend/ resume. (this is the actual issue with it)

But this is unrelated to only exposing connected devices and I should treat it as a different issue.

from xpad.

thanks for the hint regarding listening to the adapter. will try it as soon as I have some time

from xpad.

Really, you can just hold some global state that can track when controllers are connected.

Using the interface number would break when used in combination with wired controllers.

from xpad.

works 👍

from xpad.