Contracts migration v9 to v10 is failling about substrate HOT 6 CLOSED

cc @pgherveou

from substrate.

Looks like the migration code is hitting an assert error because the deposit account is empty, let me try to figure out why and come back to you.
Thanks for all the explanation for compiling and reproducing the bug, this makes my life much easier :)

from substrate.

Looking into it

from substrate.

@SailorSnoW was 0.9.43 the first version of the pallet or did you go through other migrations before?

from substrate.

Looks like we only introduced migrations at a later point, and because the code you are running on already includes the updates defined in v10.rs, the solution here is to change the migration code to:

@athei lmk if I got the history wrong here

M runtime/symphonie/src/lib.rs
@@ -777,7 +777,7 @@ impl pallet_contracts::Config for Runtime {
 	type MaxDebugBufferLen = ConstU32<{ 2 * 1024 * 1024 }>;
 	#[cfg(not(feature = "runtime-benchmarks"))]
 	type Migrations = (
-		pallet_contracts::migration::v10::Migration<Runtime>,
+		pallet_contracts::NoopMigration<10>,
 		pallet_contracts::migration::v11::Migration<Runtime>,
 		pallet_contracts::migration::v12::Migration<Runtime>,
 	);

from substrate.

Perfect that worked great, thanks :)
I wasn't aware of NoopMigration doing a dummy migration by just upgrading the pallet version so yeah that was what I needed.

from substrate.