Comments (5)
BUT: the fix I just described causes this to fail [[!include navigation]]
from instiki.
That's the same way interweb WikiLinks work. Don't you think they should be consistent?
from instiki.
I just tested it, interweb WikiLinks work both using the display name and the address. I had always been using the address, and assumed on the basis of consistency that the new include statement would use that as well.
If I were designing it from scratch I would use address consistently everywhere, as it feels more permanent, doesn't contain spaces and capitalization; it's an identifier. It would be good to be able to tweak the display name of a web without breaking links to its pages.
But that would break backward compatibility. If it were me I would still deprecate it, and use just address in the new syntax.
But we're getting into subjective judgement calls. Whatever you decide the intended behavior to be is fine, I'll follow that.
from instiki.
Actually, either the name or address (with the name preferred) are allowed for interweb WikiLinks.
So we should do the same here. Added in 60db4d4. Tweaked in f6f5482.
from instiki.
P.S.: You can perfectly well comment on a closed issue and even (if you were the one who opened it) reopen the issue. No need to open a new one, merely to add a comment.
from instiki.
Related Issues (20)
- Invalid search expressions lead to internal error HOT 1
- View Original Page Source when Editing Page HOT 7
- Search result page broken (not valid xml) HOT 1
- Emojis in wiki pages not working when editing page HOT 5
- MySQL UTF8 not working after DB restore HOT 3
- Redirection to localhost HOT 3
- Unable to Install of Mac 10.14.6 HOT 7
- Heroku Install Error HOT 18
- Interweb links not working with [[!include web:pagename]] HOT 2
- Minor tweaks to improve page creation workflow HOT 3
- Simple way to disable MathJax? HOT 2
- Edit on Heroku deploy results in "undefinedundefined" on sub pages HOT 2
- SVG creation does not work, Instiki 0.30.2(MML+), Heroku, HOT 6
- Running Instiki with Ruby 3.0 HOT 5
- Cache expiration race conditions HOT 15
- Missing index for wiki_references causes high loading times HOT 3
- Broken page cache expiration logic HOT 9
- Instiki Gemfile broken after release of Rack 3 HOT 2
- Dockerfile fails to build HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from instiki.