Spec question on UInt64 requirement and language results for sizes about paseto HOT 7 CLOSED

My solution would be: Always would set the MSB to 0, for interoperability with languages that don't have unsigned integer support.

be instructed to throw if the most significant bit is ever populated (i.e. the result is greater than something like UInt64.max/2).

+1

from paseto.

Seems reasonable (that's how I've got it implemented at the moment even). This just a request to clarify the spec a little for this case :)

from paseto.

e4b7548 should be adequate for disambiguating the documentation. Good call on reporting this 👍

from paseto.

LGTM!

PHP only has signed ints, so isn't & PHP_INT_MAX the identity map? ;p

from paseto.

Yep. I included it since this is the reference implementation, and it'll decrease the odds that somebody accidentally overlooks it and somehow signs a 2^63+1 length message one day in another language.

from paseto.

Aha, yeah okay that makes sense.

In that case maybe even something like $signedInt64Max = PHP_INT_MAX would make it abundantly clear (since unsigned ints are mentioned in the doc block), but at some point people should read the spec, or at least look up what PHP_INT_MAX refers to so 🤷‍♂️.

from paseto.

aidantwoods/swift-paseto@8ad4740 addresses this at my end.

from paseto.