Comments (5)
HI, if this issue is acked, can I take this, since I fixed the issue and tested locally, it works fine
from reth.
HI, if this issue is acked, can I take this, since I fixed the issue and tested locally, it works fine
unclear what you mean here, you mean this can be closed or you want to work on this?
tbh this looks more like a op-node issue, that can be fixed with a toLowercase() ?
from reth.
HI, if this issue is acked, can I take this, since I fixed the issue and tested locally, it works fine
unclear what you mean here, you mean this can be closed or you want to work on this? tbh this looks more like a op-node issue, that can be fixed with a toLowercase() ?
right, I mean if we can change unknow
to upper case, I can raise a pr. Of course we can fix it on op-node too.
Since there are forks from op-node like opbnb, if we can change it to upper case in reth, we can save prs for the forks of optimism. What do you think?
from reth.
HI, if this issue is acked, can I take this, since I fixed the issue and tested locally, it works fine
unclear what you mean here, you mean this can be closed or you want to work on this? tbh this looks more like a op-node issue, that can be fixed with a toLowercase() ?
right, I mean if we can change
unknow
to upper case, I can raise a pr. Of course we can fix it on op-node too.Since there are forks from op-node like opbnb, if we can change it to upper case in reth, we can save prs for the forks of optimism. What do you think?
IIRC this has since been changed in op-node, see #8355
So if this is opbnb specific, opbnb should rebase so that it captures the recent changes
from reth.
HI, if this issue is acked, can I take this, since I fixed the issue and tested locally, it works fine
unclear what you mean here, you mean this can be closed or you want to work on this? tbh this looks more like a op-node issue, that can be fixed with a toLowercase() ?
right, I mean if we can change
unknow
to upper case, I can raise a pr. Of course we can fix it on op-node too.
Since there are forks from op-node like opbnb, if we can change it to upper case in reth, we can save prs for the forks of optimism. What do you think?IIRC this has since been changed in op-node, see #8355
So if this is opbnb specific, opbnb should rebase so that it captures the recent changes
sorry, u are right, it seems it's the fault of opbnb, will close the issue.
from reth.
Related Issues (20)
- Tracking: In-memory compliance for `BlockchainProvider2`
- Add threshold for how many blocks can be persisted
- Make additional validation tasks configurable via CLI
- Start failed on 1.0.4 (e24e4c77): invalid value: string "full". HOT 3
- Add Stream type for the pending block
- Cannot compiler `reth-chain-state` on today's (2024-08-08) commit ea25df HOT 1
- Op-reth v1.0.4 broken debug_traceBlockByNumber HOT 1
- bad block with non-zero gas precompile - follow-up
- Only mark propagated txs as seen HOT 1
- SIGSEGV
- Properly bubble up `InsertBlockFatalError` HOT 2
- track persistence duration HOT 5
- extract persistence event handling into standalone functions HOT 2
- Add metrics for dropped outgoing messages HOT 5
- ExEx starts up and exits afterwards without any error/warning HOT 2
- Ensure peer receives all new transactions
- Extract test generation from derive macros
- Make `BlockchainProvider2` requests methods aware of in-memory state
- Make sync metrics work for engine2
- feature req: Need logIndex in type CallLogFrame when invoke API debug_trace* HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reth.