Describe the bug When running op-reth in dev mode with block time

yeah, but this will fail for ethereum's dev node, we need to add a <code class="notran

After a quick inspection, it seems AutoSeal does not set the <code class="notranslate"

I think it maybe related with <div class="Box Box--co

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

op-reth dev mode: Failed to insert downloaded block: receipt root mismatch about reth HOT 5 CLOSED

Troublor commented on July 18, 2024

op-reth dev mode: Failed to insert downloaded block: receipt root mismatch

from reth.

Comments (5)

jsvisa commented on July 18, 2024 1

yeah, but this will fail for ethereum's dev node, we need to add a feature to seperate them.

from reth.

Troublor commented on July 18, 2024

After a quick inspection, it seems AutoSeal does not set the receipts_root in the block header:

reth/crates/consensus/auto-seal/src/lib.rs

Lines 403 to 416 in 2a5c93f

 let Block { mut header, body, .. } = block.block; 

 let body = BlockBody { transactions: body, ommers, withdrawals, requests }; 

 trace!(target: "consensus::auto", ?execution_outcome, ?header, ?body, "executed block, calculating state root and completing header"); 

 // calculate the state root 

 header.state_root = db.state_root(execution_outcome.state())?; 

 trace!(target: "consensus::auto", root=?header.state_root, ?body, "calculated root"); 

 // finally insert into storage 

 self.insert_new_block(header.clone(), body); 

 // set new header with hash that should have been updated by insert_new_block 

 let new_header = header.seal(self.best_hash);

from reth.

jsvisa commented on July 18, 2024

~~I think it maybe related with~~

reth/crates/primitives/src/proofs.rs

Lines 43 to 71 in 7bfc604

 pub fn calculate_receipt_root_optimism( 

 receipts: &[ReceiptWithBloom], 

 chain_spec: &reth_chainspec::ChainSpec, 

 timestamp: u64, 

 ) -> B256 { 

 // There is a minor bug in op-geth and op-erigon where in the Regolith hardfork, 

 // the receipt root calculation does not include the deposit nonce in the receipt 

 // encoding. In the Regolith Hardfork, we must strip the deposit nonce from the 

 // receipts before calculating the receipt root. This was corrected in the Canyon 

 // hardfork. 

 if chain_spec.is_fork_active_at_timestamp(reth_chainspec::Hardfork::Regolith, timestamp) && 

 !chain_spec.is_fork_active_at_timestamp(reth_chainspec::Hardfork::Canyon, timestamp) 

 { 

 let receipts = receipts 

 .iter() 

 .cloned() 

 .map(|mut r| { 

 r.receipt.deposit_nonce = None; 

 r 

 }) 

 .collect::<Vec<_>>(); 

 return ordered_trie_root_with_encoder(receipts.as_slice(), |r, buf| { 

 r.encode_inner(buf, false) 

 }) 

 } 

 ordered_trie_root_with_encoder(receipts, |r, buf| r.encode_inner(buf, false)) 

 }

~~try to investigate and fix it~~

from reth.

jsvisa commented on July 18, 2024

@Troublor you're right, the receipts_root were not calculated. I'm trying to fix it.

from reth.

Troublor commented on July 18, 2024

@jsvisa FYI, I tried to added this code into build_and_execute function, it seems to work:

// calculate the receipts root
header.receipts_root = execution_outcome
    .receipts
    .optimism_root_slow(0, &chain_spec, header.timestamp)
    .expect("receipts root should never be none");

from reth.

op-reth dev mode: Failed to insert downloaded block: receipt root mismatch about reth HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	let Block { mut header, body, .. } = block.block;
	let body = BlockBody { transactions: body, ommers, withdrawals, requests };

	trace!(target: "consensus::auto", ?execution_outcome, ?header, ?body, "executed block, calculating state root and completing header");

	// calculate the state root
	header.state_root = db.state_root(execution_outcome.state())?;
	trace!(target: "consensus::auto", root=?header.state_root, ?body, "calculated root");

	// finally insert into storage
	self.insert_new_block(header.clone(), body);

	// set new header with hash that should have been updated by insert_new_block
	let new_header = header.seal(self.best_hash);

	pub fn calculate_receipt_root_optimism(
	receipts: &[ReceiptWithBloom],
	chain_spec: &reth_chainspec::ChainSpec,
	timestamp: u64,
	) -> B256 {
	// There is a minor bug in op-geth and op-erigon where in the Regolith hardfork,
	// the receipt root calculation does not include the deposit nonce in the receipt
	// encoding. In the Regolith Hardfork, we must strip the deposit nonce from the
	// receipts before calculating the receipt root. This was corrected in the Canyon
	// hardfork.
	if chain_spec.is_fork_active_at_timestamp(reth_chainspec::Hardfork::Regolith, timestamp) &&
	!chain_spec.is_fork_active_at_timestamp(reth_chainspec::Hardfork::Canyon, timestamp)
	{
	let receipts = receipts
	.iter()
	.cloned()
	.map(\|mut r\| {
	r.receipt.deposit_nonce = None;
	r
	})
	.collect::<Vec<_>>();

	return ordered_trie_root_with_encoder(receipts.as_slice(), \|r, buf\| {
	r.encode_inner(buf, false)
	})
	}

	ordered_trie_root_with_encoder(receipts, \|r, buf\| r.encode_inner(buf, false))
	}