Giter Club home page Giter Club logo

Comments (3)

andrzejSulkowski avatar andrzejSulkowski commented on July 22, 2024

I can take this one but I'd need further information.

  • Where should I re-export the types in our repo (as alloy-eips is a separate library)?
  • Feature Gate means to include a feature like #![cfg(feature = "optimism")]?
  • Is the feature name "alloy-rpc-conversion" suitable?

from reth.

mattsse avatar mattsse commented on July 22, 2024

Where should I re-export the types in our repo (as alloy-eips is a separate library)?

this is already the case, for example:

reth/crates/primitives/src/withdrawal.rs

Lines 7 to 9 in 1f6753b

/// Re-export from `alloy_eips`.
#[doc(inline)]
pub use alloy_eips::eip4895::Withdrawal;

this issue mainly concerns these conversions:

reth/crates/primitives/src/block.rs

Line 151 in 1f6753b

impl TryFrom<reth_rpc_types::Block> for Block {

it looks like this issue is blocked by #7928 and #7929

but we could already introduce the alloy-compat feature for the tryfrom conversions

from reth.

andrzejSulkowski avatar andrzejSulkowski commented on July 22, 2024

will be done

from reth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.