[BUG] Workflow with empty "filter sources" never matches anything about paperless-ngx HOT 4 CLOSED

Worth mentioning: I have not tested any of the other form fields. I have not tested any of the other trigger types (and I know those will lead to different form fields).

Whoever investigates (and fixes) this bug, please take a look at all form fields to make sure they all behave consistently.

from paperless-ngx.

To a certain extent, this is user error. It seems clear enough that no sources will match nothing. We can probably add some validation to prevent empty sources though

from paperless-ngx.

In my humble opinion, it's not "clear enough".

Following the logic of "no sources will match nothing", we would expect that no filter path will match nothing as well. It's inconsistent among the form fields.

I believe the best option is to make "no sources" simply disable the source-checking, just like empty path also disables the path-checking.

If that is not possible, I agree with you regarding adding some validation to warn the user about invalid trigger conditions.

(EDIT) I did a quick research in the codebase:

• Tag filter is only active if the trigger has any tag defined:

  paperless-ngx/src/documents/matching.py

  Lines 335 to 341 in d55900b

  	if (
  	trigger.filter_has_tags.all().count() > 0
  	and document.tags.filter(
  	id__in=trigger.filter_has_tags.all().values_list("id"),
  	).count()
  	== 0
  	):

• Correspondent filter is only active if the correspondent was set in the trigger:

  paperless-ngx/src/documents/matching.py

  Lines 349 to 352 in d55900b

  	if (
  	trigger.filter_has_correspondent is not None
  	and document.correspondent != trigger.filter_has_correspondent
  	):

• Document type filter is only active if the document type was set in the trigger:

  paperless-ngx/src/documents/matching.py

  Lines 359 to 362 in d55900b

  	if (
  	trigger.filter_has_document_type is not None
  	and document.document_type != trigger.filter_has_document_type
  	):

• Filename filter is only active if the filename glob was set in the trigger:

  paperless-ngx/src/documents/matching.py

  Lines 369 to 377 in d55900b

  	if (
  	trigger.filter_filename is not None
  	and len(trigger.filter_filename) > 0
  	and document.original_filename is not None
  	and not fnmatch(
  	document.original_filename.lower(),
  	trigger.filter_filename.lower(),
  	)
  	):

  and

  paperless-ngx/src/documents/matching.py

  Lines 281 to 288 in d55900b

  	if (
  	trigger.filter_filename is not None
  	and len(trigger.filter_filename) > 0
  	and not fnmatch(
  	document.original_file.name.lower(),
  	trigger.filter_filename.lower(),
  	)
  	):

• Mailrule filter is only active if it was set in the trigger:

  paperless-ngx/src/documents/matching.py

  Lines 269 to 273 in d55900b

  	if (
  	document.mailrule_id is not None
  	and trigger.filter_mailrule is not None
  	and document.mailrule_id != trigger.filter_mailrule.pk
  	):

• And, yet, the document source is always active, regardless if it was set in the trigger or left empty:

  paperless-ngx/src/documents/matching.py

  Line 261 in d55900b

  if document.source not in [int(x) for x in list(trigger.sources)]:

It really sounds like an oversight, and I think it leads to surprising behavior for the user.

from paperless-ngx.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

from paperless-ngx.