Giter Club home page Giter Club logo

Comments (4)

paolostivanin avatar paolostivanin commented on June 2, 2024

@magiruuvelvet please let's continue the discussion here, thx :)

from libcotp.

magiruuvelvet avatar magiruuvelvet commented on June 2, 2024

DIGITS_POWER[digits_length]

There is an array out of bound when the digit size is greater than 8. I just increased the array with more values.

I'm on Linux btw and compiled with clang. The behavior is undefined, but should normally result in a segfault I guess.

from libcotp.

paolostivanin avatar paolostivanin commented on June 2, 2024

Yep, you're right! I was able to reproduce the issue with >= 15 digits. Increasing the array size is not enough though, there are some other fixes that are needed :)

from libcotp.

paolostivanin avatar paolostivanin commented on June 2, 2024

Supporting tokens with long digits (> 10) would require a bigger refactoring and I don't really have time for that. I want to focus on OTPClient v1.3.0 rather than supporting a non existing use case :)
I looked online and no one is using more than 8 digits, so for the time being the max supported digits will be 10

from libcotp.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.