Comments (4)
@magiruuvelvet please let's continue the discussion here, thx :)
from libcotp.
DIGITS_POWER[digits_length]
There is an array out of bound when the digit size is greater than 8. I just increased the array with more values.
I'm on Linux btw and compiled with clang. The behavior is undefined, but should normally result in a segfault I guess.
from libcotp.
Yep, you're right! I was able to reproduce the issue with >= 15 digits. Increasing the array size is not enough though, there are some other fixes that are needed :)
from libcotp.
Supporting tokens with long digits (> 10) would require a bigger refactoring and I don't really have time for that. I want to focus on OTPClient v1.3.0 rather than supporting a non existing use case :)
I looked online and no one is using more than 8 digits, so for the time being the max supported digits will be 10
from libcotp.
Related Issues (18)
- Add pkg-config file
- Add steam support
- Add support for 60s tokens
- License collision with libbaseencode HOT 6
- SOVERSION should be set manually HOT 1
- Add option in CMakeLists to enable tests
- Add support for custom digits
- Exception running... HOT 4
- Tests should not need install to build
- No package 'baseencode' found HOT 2
- pkg-config file is broken when CMAKE_INSTALL_{INCLUDE,LIB}DIR is absolute HOT 4
- Tests are failing HOT 1
- improve docu
- error while building HOT 4
- Openssl support? HOT 5
- Is it compatible with Google Authenticator? HOT 5
- Add battle.net support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libcotp.