Giter Club home page Giter Club logo

Comments (4)

panzerdp avatar panzerdp commented on May 18, 2024

Prune doesn't allow having non-word characters (like punctuation characters) after the last word. This increases the readability of the truncated phrase.

For example, this is better in sense of truncation:

v.prune('Good day. Little Red Riding Hood', 16, '...');
// => 'Good day...'

Compared to:

v.prune('Good day. Little Red Riding Hood', 16, '...');
// => 'Good day. ...'

from voca.

mattiaerre avatar mattiaerre commented on May 18, 2024

thanks @panzerdp for the quick answer, really appreciated; my point is that this is not always the case as this is what's happening now:

expect(v.prune('YATTA,', 6, '')).toEqual('YATTA,');
expect(v.prune('YATTA, ', 6, '')).toEqual('YATTA');

the 1st string w/o a final empty space returns the comma, the second one w/ space doesn't; using your example:

  expect(v.prune('Good day. Little Red Riding Hood,', 12, '')).toEqual(
    'Good day'
  );
  expect(v.prune('Good day. Little Red Riding Hood,', 33, '')).toEqual(
    'Good day. Little Red Riding Hood,'
  );

the 1st string does not return the punctuation.
thanks again,
-Mattia

from voca.

panzerdp avatar panzerdp commented on May 18, 2024

Prune is applied (including the removal of non-word chars) only when the string length is bigger than prune length. Otherwise the string is not modified, because there's nothing to remove.

from voca.

mattiaerre avatar mattiaerre commented on May 18, 2024

oh I see @panzerdp although I still think that

v.prune('YATTA, ', 6, '')

should return

YATTA, w/ the comma

and not

YATTA

from voca.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.