Giter Club home page Giter Club logo

Comments (2)

cggarvey avatar cggarvey commented on September 21, 2024 1

I think that makes sense. Defaulting to 0 probably makes sense (although technically it should be NULL/None until the inning begins). Something like this should work.

home = 0
away = 0

with contextlib.suppress(KeyError):
    # home/away attributes may not exist during rain delays 
    home = x.attrib['home']
    away = x.attrib['away']

Edit: Scratch that. I misread your sample xml. We'd need to error-handle them separately since there could be an away attribute but not home.

home = 0
away = 0

# home/away attributes may not exist during rain delays 
with contextlib.suppress(KeyError):
    home = x.attrib['home']

with contextlib.suppress(KeyError):
    away = x.attrib['away']

from mlbgame.

msroth avatar msroth commented on September 21, 2024

I have experienced the same error with a suspended game (2018_05_15_nyamlb_wasmlb_1). I have also observed this when I happen to catch a game in the middle of an inning and the <inning_line_score> element contains an 'inning' and 'away' attribute, but no 'home' yet. I will make the edit suggested by cggarvey in the game.py module until an official fix is in place.

from mlbgame.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.