Giter Club home page Giter Club logo

Comments (8)

bleibold avatar bleibold commented on June 19, 2024

Additional information: The Edge arrow that is defaulted to a canvas position of (0,0) happens to be an arrow on the single visible edge path that is supposed to be hidden (Invisible). If when the graph is generated this edge arrow that is shown at (0,0) was visible, then the edge would draw properly.

from graphx.

bleibold avatar bleibold commented on June 19, 2024

Defect appears to be fixed:

The following method in EdgeControlBase.cs was changed to fix this issue. There is a need to check the existing Visibility property, which may be set by a Binding and/or Converter.

    /// <summary>
    /// Internal. Update only edge points andge edge line visual
    /// </summary>
    /// <param name="updateLabel"></param>
    internal virtual void UpdateEdgeRendering(bool updateLabel = true)
    {
        if (!IsTemplateLoaded)
            ApplyTemplate();
        if (ShowArrows)
        {
            // Note: Do not override a possible WPF Binding or Converter for the Visibility property.
            if (EdgePointerForSource?.Visibility == Visibility.Visible)
                EdgePointerForSource?.Show();

            // Note: Do not override a possible WPF Binding or Converter for the Visibility property.
            if (EdgePointerForTarget?.Visibility == Visibility.Visible)
                EdgePointerForTarget?.Show();
        }
        else
        {
            EdgePointerForSource?.Hide();
            EdgePointerForTarget?.Hide();
        }
        PrepareEdgePath(true, null, updateLabel);
        if (LinePathObject == null) return;
        LinePathObject.Data = Linegeometry;
        LinePathObject.StrokeDashArray = StrokeDashArray;
    }

I have tested this and it appears to be a solid fix, but the author of the latest changes should review.

from graphx.

bleibold avatar bleibold commented on June 19, 2024

Requested 2 Pulls, but both failed through AppVeyor for unknown reason?

from graphx.

panthernet avatar panthernet commented on June 19, 2024

Hi, thanks for the fix. The AppVeyor fails due to certificate error in UWP version and I don't know right now how to fix it.

from graphx.

bleibold avatar bleibold commented on June 19, 2024

from graphx.

bleibold avatar bleibold commented on June 19, 2024

from graphx.

panthernet avatar panthernet commented on June 19, 2024

Hi, this is because edge can now have several labels attached both with their own visibility settings. Single edge or graphArea edge label visibility property would touch all the labels and it would be wrong logic here. Label visibility property along with some other abel properties has been moved to the label control itself so each of them can be controlled separately. Initial edge label visibility could be changed with methods, template or label factory. If you think that there is a better approach please let me know.

from graphx.

bleibold avatar bleibold commented on June 19, 2024

from graphx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.