Comments (8)
Additional information: The Edge arrow that is defaulted to a canvas position of (0,0) happens to be an arrow on the single visible edge path that is supposed to be hidden (Invisible). If when the graph is generated this edge arrow that is shown at (0,0) was visible, then the edge would draw properly.
from graphx.
Defect appears to be fixed:
The following method in EdgeControlBase.cs was changed to fix this issue. There is a need to check the existing Visibility property, which may be set by a Binding and/or Converter.
/// <summary>
/// Internal. Update only edge points andge edge line visual
/// </summary>
/// <param name="updateLabel"></param>
internal virtual void UpdateEdgeRendering(bool updateLabel = true)
{
if (!IsTemplateLoaded)
ApplyTemplate();
if (ShowArrows)
{
// Note: Do not override a possible WPF Binding or Converter for the Visibility property.
if (EdgePointerForSource?.Visibility == Visibility.Visible)
EdgePointerForSource?.Show();
// Note: Do not override a possible WPF Binding or Converter for the Visibility property.
if (EdgePointerForTarget?.Visibility == Visibility.Visible)
EdgePointerForTarget?.Show();
}
else
{
EdgePointerForSource?.Hide();
EdgePointerForTarget?.Hide();
}
PrepareEdgePath(true, null, updateLabel);
if (LinePathObject == null) return;
LinePathObject.Data = Linegeometry;
LinePathObject.StrokeDashArray = StrokeDashArray;
}
I have tested this and it appears to be a solid fix, but the author of the latest changes should review.
from graphx.
Requested 2 Pulls, but both failed through AppVeyor for unknown reason?
from graphx.
Hi, thanks for the fix. The AppVeyor fails due to certificate error in UWP version and I don't know right now how to fix it.
from graphx.
from graphx.
from graphx.
Hi, this is because edge can now have several labels attached both with their own visibility settings. Single edge or graphArea edge label visibility property would touch all the labels and it would be wrong logic here. Label visibility property along with some other abel properties has been moved to the label control itself so each of them can be controlled separately. Initial edge label visibility could be changed with methods, template or label factory. If you think that there is a better approach please let me know.
from graphx.
from graphx.
Related Issues (20)
- The sample application not building
- [MVVM] Vertices text is not showing up correctly HOT 2
- Background Image of Vertex HOT 3
- How to remove label edge? HOT 2
- How to remove minimap of the view finder?
- How to export graph to png?
- Slow Drag Vertex
- Implementation of the mvvm model with GraphX
- Initialization error on pass false to tracePositionChange of VertexControl Constructor
- Graph virtualization
- is it possible to add new verticies/edges without having a full relayout of the graph?
- How to make arrows?
- How to make edges doesn't cross HOT 3
- How to add double click event to a vertex HOT 2
- How to change the type of edges?
- Release nuget version with support for QuikGraph HOT 1
- recent development HOT 1
- strange behavior HOT 2
- Edges with same source and target rendered as a star instead of an edge? HOT 1
- the additional api website is currently unavailable
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphx.