Lua3rdDLL.open(L) takes about 1.3 sec but doing nothing about slua HOT 13 CLOSED

These codes were contributed by @wlgys8 , I think should optimize

from slua.

I have profiled, but didn't get similar output, I found gc alloc need 6MB and take 150ms on pc.

I have reviewed the code and modified a little for reduce gc alloc, after my modification, gc alloc need 345kb and take 26ms.

My modification had pushed.

btw, how did you test GC alloc and found them went up to 37mb?

from slua.

I just retested result as follows
without profiler

find all methods marked by [Lua3rdRegAttribute] cost :0.5860335

profiler result

then I remove Lua3rdDLL.open(L)

The problem of Lua3rdDLL.open(L) is the function actually doing nothing (to me because I don't have any 3rdDll to be imported). It should be able to disable and enable when needed.
BTW I am pretty new to Unity my conclusion might not very accurate, Thank.

from slua.

I added a flag to control whether switch on debug/open extlib/reg 3rddll or not, not need reg 3rddll as default for most user.

from slua.

Notice my capture, xxx (xxx is profile pair)only need 0.7M gc-alloc and take 56ms on pc(latest version), I think you should expand profile tree to scrutinize what's hot spot.

Profiler.BeginSample("xxxx");
Lua3rdDLL.open(L);
Profiler.EndSample();

from slua.

Thanks !

Expanding profile tree on just halted my shitty machine...

Profiler.BeginSample("xxxx");
Lua3rdDLL.open(L);
Profiler.EndSample();

I will give this a try.

from slua.

New test with Profiler.BeginSample defined

old code

With your latest Fix

Lua3rdDLL.open(L); Removed

from slua.

Did you did some 3rd dll reg work?

from slua.

I get it, your assembly contains much functions, I had added a binding flat to reduce list of function that are returned by x.GetMethods

from slua.

Yes I bought quite a few plugins with dlls such as Json.Net for Unity.

from slua.

            foreach(var assem in AppDomain.CurrentDomain.GetAssemblies()){
                if(assem.GetName().Name == "Assembly-CSharp"){
                    assembly = assem;
                }
            }

break is needed when assembly is found I guess.

from slua.

I think so ,had fixed

from slua.

maybe auto search is not a good solution here?
ease use but time costing.
register 3rd DLL manually seems better?

from slua.