missing image on load page about pangeo-binder HOT 11 CLOSED

Yes, we should fix this. I'm not sure why this isn't working. I think this page should be inhereting from the 'page.html' but something does seem to be broken.

https://github.com/pangeo-data/pangeo-custom-binderhub-templates/blob/0216d32700742c5c31204fd8be0198f25eba10d2/templates/page.html#L18-L28

I'd bet @dsludwig knows what's up here.

from pangeo-binder.

If anyone wants to fix this in the next 10 minutes that would be great. 😜

from pangeo-binder.

It's due to the url prefix being a relative URL, which evaluates differently on different pages. #16 should fix it.

from pangeo-binder.

Hmmm, this still seems to be a problem. Will look into it more.

from pangeo-binder.

This appears to be now fixed.

from pangeo-binder.

I'm still seeing:

from pangeo-binder.

You are right. I was looking at the wrong page

from pangeo-binder.

This is the URL we are looking for. It exists
https://binder.pangeo.io/extra_static/pangeo_simple_logo.svg

The logo link is rending as

<img id="logo" src="extra_static/pangeo_simple_logo.svg" width="390px"  />

with a relative, rather than absolute, URL.

The problem is with these lines:

@minrk added the extra / to url prefix. But it didn't work. Does it need to be in quotes perhaps?

from pangeo-binder.

@rabernat - I just tried with your attempt -- no joy!. Now the image is coming from: https://staging.binder.pangeo.io/v2/gh/jhamman/dask-examples/extra_static/pangeo_simple_logo.svg

So we need to strip out the repo info: https://staging.binder.pangeo.io/extra_static/pangeo_simple_logo.svg

from pangeo-binder.

@jhamman @rabernat I think the problem is in page.html: https://github.com/pangeo-data/pangeo-custom-binderhub-templates/blob/master/templates/page.html#L22

Leading / is missing. It should be like:

        <img id="logo" src={% block logo_image %}"/extra_static/pangeo_simple_logo.svg"{% endblock logo_image %} width="390px"  />

pangeo-data/pangeo-custom-binderhub-templates#2 didn't fix the logo in loading page because loading page uses loading.html not index.html.

I would also delete logo_image block in index.html (https://github.com/pangeo-data/pangeo-custom-binderhub-templates/blob/master/templates/index.html#L10), since index.html is extending page.html and they have the same logo.

from pangeo-binder.

Thanks @bitnik. That gets us closer. Any idea why the change in pangeo-data/pangeo-custom-binderhub-templates@17bfade would cause the page header css to be stripped out?

from pangeo-binder.