Giter Club home page Giter Club logo

Comments (6)

achapkowski avatar achapkowski commented on September 26, 2024

To follow up, this PR #55314 is the breaking change.

from pandas.

dontgoto avatar dontgoto commented on September 26, 2024

As outlined in the PR, deepcopy was introduced to prevent unwanted side effects when attrs are used and propagated.

The failure mode of using a class without __deepcopy__ is transparent, just like the fix required (implement deepcopy) to be able to use attrs with the custom class.

On the other hand, side effects from not deepcopy'ing attrs in the background are intransparent to the end user. So in the end using deepcopy is probably preferable.

from pandas.

Compro-Prasad avatar Compro-Prasad commented on September 26, 2024

@achapkowski Maybe try df.attrs["metadata"] = {**InsensitiveDict(data)}.

from pandas.

Compro-Prasad avatar Compro-Prasad commented on September 26, 2024

@achapkowski Since you are making a custom implementation of a dictionary, you can implement a __deepcopy__ like this:

    def __deepcopy__(self, memo):
        result = InsensitiveDict(deepcopy({**self}))
        memo[id(self)] = result
        return result

from pandas.

achapkowski avatar achapkowski commented on September 26, 2024

I know I can implement deepcopy, but the issue is if I use any 3rd party library, like this class from requests, I have to monkey patch it.

from pandas.

achapkowski avatar achapkowski commented on September 26, 2024

How is it problematic? From what I read it's a problem with geopandas not pandas. This is a major regression because most classes and packages do not implement deepcopy.

from pandas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.