Giter Club home page Giter Club logo

Comments (6)

danizen avatar danizen commented on July 17, 2024 1

I have tested with Django 3.2 and added it to the build matrix. I am stopped from a good pull request by two things:

  • Travis-CI.org shutdown awhile ago, and so I would have to go through a lot to test that Python 2.7 still works. Dropping support for Python 2.7 and Django 1.11 would make me confident - without them I would want a build bot.

  • A better fix would not require a work-around on Windows for BUILD_DIR setting. So, I want to understand an OSFS is supposed to work on Windows. My intuition is that the BUILD_ROOT should be validated with os.path and then opened as a filesystem itself, and the relative path is what should be validated. However, I am not certain and want to wait for PyFilesystem/pyfilesystem2#526

from django-bakery.

palewire avatar palewire commented on July 17, 2024

I'm okay with hammering out a short term fix to get it working for you. I am open to deprecating python-fs in favor of pathlib.

from django-bakery.

danizen avatar danizen commented on July 17, 2024

I just did a "python setup.py test", and it looks like some requirements would need to be pinned for me to test successfully. Some of these are in test code, and so pinning Django==2.2 might be acceptable to deal with this for now. I may need to do more changes than I expected.

from django-bakery.

danizen avatar danizen commented on July 17, 2024

Is a live bucket required to run tests? Can that be easily parameterized?

from django-bakery.

palewire avatar palewire commented on July 17, 2024

It's been a good while since I worked through these details, but I'm pretty sure Travis pulls it off with a mock.

https://github.com/palewire/django-bakery/blob/master/.travis.yml#L13-L49

from django-bakery.

danizen avatar danizen commented on July 17, 2024

I see. The intention is to define AWS_ACCESS_KEY_ID and so on to make sure that we are not mutating any real environment, as described in moto documentation.

The issue is resolved for me with small changes to the tests, I think deriving from changes in how the moto API works - it patches now on client or resource creation I think. The boto API has also changed a little and I also had to use kwargs only in a couple of places in tests. Might not have needed to do if I got the mocking right first.

danizen@4b655d8

I am testing now only with Django 2.2, but I saw there were some issues with Django 4. I will give more recent versions of Django a try tomorrow.

from django-bakery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.