Giter Club home page Giter Club logo

Comments (3)

thammi avatar thammi commented on May 21, 2024

Comment by janlelis
Wednesday Oct 08, 2014 at 13:36 GMT


thank you! looks good to me. some related things i've noticed:

  • bower.json is missing jquery
  • we should provide a bundle with all dependencies... should this even be in the .min. ("production") version so you can just drop it into your code and it works?

from palava.

thammi avatar thammi commented on May 21, 2024

Comment by thammi
Saturday Oct 11, 2014 at 15:57 GMT


Bundling the dependencies without a mechanism like require()/AMD/... would pollute the namespace of the user and might cause version conflicts if the user manually includes the libraries.

from palava.

thammi avatar thammi commented on May 21, 2024

Comment by janlelis
Saturday Oct 11, 2014 at 21:05 GMT


@thammi I agree. What I have in mind is providing an extra version (and don't bundle deps into "palava.js"

from palava.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.