Giter Club home page Giter Club logo

Comments (1)

janlelis avatar janlelis commented on June 18, 2024

As noted in palavatv/palava#42 (comment), muting already works, so the following steps need to be done to implement this:

  • Reactivate control knobs:
    <!-- <transition name="fade-control">
    <button
    :title="$t('party.turnOffCameraTitle')"
    class="control control--camera"
    v-if="controlsActive"
    >
    <inline-svg
    :alt="$t('party.cameraAlt')"
    :aria-label="$t('party.cameraAlt')"
    :src="require('../assets/video-camera.svg')"
    />
    </button>
    </transition> -->
    <!-- <transition name="fade-control">
    <button
    :title="$t('party.muteMicrophoneTitle')"
    class="control control--microphone"
    v-if="controlsActive"
    >
    <inline-svg
    :alt="$t('party.microphoneAlt')"
    :aria-label="$t('party.microphoneAlt')"
    :src="require('../assets/mic.svg')"
    />
    </button>
    </transition> -->
  • Only show mute knob is local stream has audio (same with video)
  • Track own mute / video-sending state in the party components' state (data:), both knobs should let you toggle these states, see
    <button
    :title="muted ? $t('peer.unmuteAudioTitle') : $t('peer.muteAudioTitle')"
    :class="{
    'menu-control': true,
    'menu-control--mute': !muted,
    'menu-control--unmute': muted,
    }"
    ref="mute"
    v-if="peerMenuActive && !peer.isLocal() && peer.hasAudio() && !peer.hasError()"
    @click="toggleMute()"
    >
    for inspriation (also note that the svgs for both states are already available in the assets folder)
  • Actual mute functionality to be triggered is here: https://github.com/palavatv/palava-client/blob/master/coffee/local_peer.coffee#L70
  • Put video on hold still needs to be implemented in the client library

from palava-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.