Node modules are not installed about npm-install HOT 6 CLOSED

This is working as expected since we merged paketo-buildpacks/npm-start#179. Can you explain why you expect this to work without specifying a start command?

from npm-install.

Some of the NodeJS apps we build use Procfiles or are started with custom docker start commands rather than using a package.json start command. The build looks like it will work as the node-engine and procfie buildpacks both match, but the deps are not installed so the app fails to start.

===> DETECTING
4 of 8 buildpacks participating
paketo-buildpacks/ca-certificates 3.1.0
paketo-buildpacks/node-engine     0.12.1
paketo-buildpacks/node-start      0.7.1
paketo-buildpacks/procfile        5.1.0

I've added an example on this branch

It is also a bit strange how the npm behaviour does not match the yarn behaviour

from npm-install.

+1 on this, and yes @ryanmoran it was caused by the PR you referenced, but not intended (@dalbar is a colleague of me). We also just stumbled over that the npm-start buildpack requests nodemodules. And now as it does not participate anymore, it does not request it anymore and npm-install does not jump in.

I think, conceptually it would make sense to decouple this. npm-install should imo always contribute if there is a package.json which has a non-empty dependencies or devDependencies section (depending on NODE_ENV). By default only for runtime. node-run-script would request it for build time as it does today.

Not sure what the best way is to get to this behavior.

from npm-install.

+1 on this, and yes @ryanmoran it was caused by the PR you referenced, but not intended (@dalbar is a colleague of me). We also just stumbled over that the npm-start buildpack requests nodemodules. And now as it does not participate anymore, it does not request it anymore and npm-install does not jump in.

I think, conceptually it would make sense to decouple this. npm-install should imo always contribute if there is a package.json which has a non-empty dependencies or devDependencies section (depending on NODE_ENV). By default only for runtime. node-run-script would request it for build time as it does today.

Not sure what the best way is to get to this behavior.

@ryanmoran Wouldn't it be sufficient to add an additional build group in https://github.com/paketo-buildpacks/nodejs/blob/main/buildpack.toml that install npm dependencies and runs node-start with a lower priority than the current npm-start group.

Currently the build groups are: yarn stuff, npm-install+npm-start and node-start.
With changes: yarn stuff, npm-install+npm-start, npm-install+node-start and node-start.

Ordered groups should lead to the desired behavior.

from npm-install.

This PR (paketo-buildpacks/node-start#203) will allow the node-start buildpack to pull in node_modules if needed. Once this lands, we can add node-start to both the yarn and npm order groups in the node buildpack.toml. We can then also make their respective *-start buildpacks optional. At this point, I believe we will have restored the original behavior.

@dalbar I'd also love to see a PR to yarn-start that replicates the behavior that we have today in npm-start with regard to the detection of the start command.

from npm-install.

@ryanmoran sounds like a solid plan. I will work on the yarn-start changes.

from npm-install.