Giter Club home page Giter Club logo

Comments (3)

robdimsdale avatar robdimsdale commented on July 28, 2024

@paketo-buildpacks/go-maintainers this looks like an issue with the integration test assuming a given order of go mod vendor:

The tests expect one ordering (BurntSushi/toml, then satori/go.uuid)

                <string>"  Executing build process",
                <string>"    Running 'go mod vendor'",
                <*matchers.MatchRegexpMatcher | 0xc0004e8d20>{
                    Regexp: "      go: downloading github.com/BurntSushi/toml v.+",
                    Args: nil,
                },
                <*matchers.MatchRegexpMatcher | 0xc0004e8d50>{
                    Regexp: "      go: downloading github.com/satori/go.uuid v.+",
                    Args: nil,
                },

But the buildpack actually ran in a different order (satori/go.uuid followed by BurntSushi/toml)

              Executing build process
                Running 'go mod vendor'
                  go: downloading github.com/satori/go.uuid v1.1.0
                  go: downloading github.com/BurntSushi/toml v0.3.1

I think the test can most easily be fixed by having separate statements for each of the lines - essentially abandoning ordering.

This ordering is likely non-deterministic, hence why it passed in the PR.

from go-mod-vendor.

ForestEckhardt avatar ForestEckhardt commented on July 28, 2024

I am putting a pr together that changes the regex so that is expects one of those two in each slot allowing for both to be in either position.

from go-mod-vendor.

github-actions avatar github-actions commented on July 28, 2024

Another failure occurred: https://github.com/paketo-buildpacks/go-mod-vendor/actions/runs/6281163496

from go-mod-vendor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.