Giter Club home page Giter Club logo

Comments (5)

kszymukowicz avatar kszymukowicz commented on August 23, 2024 2

Yes - that will solve the issue and your TS settings proposal is better than mine.

from typo3-formlog.

kszymukowicz avatar kszymukowicz commented on August 23, 2024 1

Sorry for late response. I was trying to find the best solution.

Actually I was inspired by the conditions here #15 and I have made a condition per form identifier like below. This solves my issue. If you want I can make a PR with docs for that solution or maybe you want to solve that possibility differently? For example by defining some way to inject TS per form identifier on TS level. (f.e. something like module.tx_formlog.settings.list._form-identifier.f1-5685 { })

My working solution:

[traverse(request.getQueryParams(), 'tx_formlog_web_formloglist/filters/identifier/value') == 'f1-5685']
    module.tx_formlog {
        settings {
            list {
               // some custom columns settings per form
            }
            export < .list
        }
    }
[global]

The idea of #17 is nice however. I suppose when my PMs will start to make own form they will need that definitely.

from typo3-formlog.

mbrodala avatar mbrodala commented on August 23, 2024 1

Giving this another thought the suggested TypoScript setup could indeed help to get this achieved.

Currently we have this:

module.tx_formlog.settings.list.columns
module.tx_formlog.settings.export.columns

Another option could be added to specify dedicated columns for each form identifier:

module.tx_formlog.settings.list.columns
module.tx_formlog.settings.export.columns

module.tx_formlog.settings.form.<identifier>.list.columns
module.tx_formlog.settings.form.<identifier>.export.columns

This could then prefer the 2nd paths if only entries from the form <identifier> are to be listed; we can determine this from the fact that the matching filter is applied. Tasks for this:

  1. Introduce the new settings path
  2. Have the dedicated columns respected in the list
  3. Have the dedicated columns respected in the export
  4. Add an indicator to the log module if form-specific column settings are used (hopefully reduces confusion about varying display and export)

from typo3-formlog.

mbrodala avatar mbrodala commented on August 23, 2024

What do you mean exactly with that?

Maybe related to #17

Here you can see that it's not that easy to implement but maybe you have a good idea.

from typo3-formlog.

mbrodala avatar mbrodala commented on August 23, 2024

Your workaround may work but it relies on two facts which cannot be taken as given:

  1. Log entries of a single form are listed
  2. The form definition never changes

By default we the list contains entries of all forms mixed, filtering by a single identifier may open up the path for exporting entries of a single form. But that form definitions may change cannot be avoided; the same form identifier can contain slightly or even completely different fields over time.

Thus this requires a good concept for a general solution which covers the most cases.

from typo3-formlog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.